From: Christoph Hellwig <hch@infradead.org>
To: Julian Sun <sunjunchao@bytedance.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, willy@infradead.org, jack@suse.cz,
tj@kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v9 2/3] memcg,writeback: flush foreign bdev mappings separately from owner wbs
Date: Sun, 27 Sep 2026 23:18:37 -0700 [thread overview]
Message-ID: <aroGvQSFpj06a_to@infradead.org> (raw)
In-Reply-To: <87e10baa-13a8-4766-8d6d-9173a4b0c5c5@bytedance.com>
On Fri, Sep 25, 2026 at 09:00:28PM +0800, Julian Sun wrote:
> Yeah..Andrew and I discussed the naming in another thread. The idea was to stay
> consistent with the existing naming and keep this patchset focused on the functional
> changes, leaving a broader naming cleanup to a separate patch.
>
> https://lore.kernel.org/linux-fsdevel/20260917065759.2643940-1-sunjunchao@bytedance.com/T/#m0d196c3b8376c9b51276f6c5d26ab9f29e170169
Let's not add more of this, even if fixing up the previous ones belongs
into a separate thread.
> >
> > Instead please fail the boot. If we can't alloc a workqueue at
> > boot time, we're toast anyway.
> I followed the existing memcg_wq allocation handling here, which also
> warns and continues. Would it make sense to change both allocations to
> fail the boot in a separate patch, so the policy is consistent?
> If you prefer to address both in this series, I'll make that change
> in the next revision.
Leaving dangling pointers during catastropic boot failures and then
dealing with them at runtime isn't a good idea. And yes, the code
above should eventually be fixed up as well.
next prev parent reply other threads:[~2026-09-28 6:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 6:44 [PATCH v9 0/3] memcg,writeback: flush foreign bdev mappings separately Julian Sun
2026-09-25 6:44 ` [PATCH v9 1/3] block: introduce bdev_flush_by_dev() Julian Sun
2026-09-25 6:52 ` Christoph Hellwig
2026-09-25 10:34 ` Jan Kara
2026-09-28 6:24 ` Christoph Hellwig
2026-09-28 9:51 ` Julian Sun
2026-10-02 11:10 ` Jan Kara
2026-10-05 8:26 ` Christoph Hellwig
2026-10-05 16:25 ` Jan Kara
2026-10-08 8:00 ` Julian Sun
2026-10-08 8:51 ` Jan Kara
2026-10-08 9:39 ` Christoph Hellwig
2026-10-02 9:23 ` Julian Sun
2026-10-05 8:27 ` Christoph Hellwig
2026-09-25 6:44 ` [PATCH v9 2/3] memcg,writeback: flush foreign bdev mappings separately from owner wbs Julian Sun
2026-09-25 6:55 ` Christoph Hellwig
2026-09-25 13:00 ` Julian Sun
2026-09-28 6:18 ` Christoph Hellwig [this message]
2026-09-25 6:44 ` [PATCH v9 3/3] writeback: add tracepoints for foreign bdev writeback Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroGvQSFpj06a_to@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=sunjunchao@bytedance.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox