From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Daniel Wagner <wagi@kernel.org>
Subject: Re: [PATCH blktests 0/5] nvme: tests for isolated CPUs and fabrics queue mapping
Date: Tue, 20 Oct 2026 15:40:53 +0900 [thread overview]
Message-ID: <atcLN4XXfNF1YSZa@shinmob> (raw)
In-Reply-To: <20261014-nvme-isolcpu-v1-0-2fd175a8ef00@kernel.org>
On Oct 14, 2026 / 09:51, Daniel Wagner wrote:
> New tests for the bugs fixed by the kernel series "nvme-fabrics: fix
> connects with isolated CPUs and queue mapping bugs":
>
> https://lore.kernel.org/linux-nvme/20261014-nvme-fabrics-isolcpu-v1-0-355156be27b2@kernel.org/
>
> nvme/070 connect with an isolated CPU (cpuset partition), verified
> I/O from a housekeeping and from the isolated CPU, traced on
> the queue of the isolated CPU
> nvme/071 more write and poll queues than online CPUs
> nvme/072 no queues left for polling
> nvme/073 reconnect with fewer I/O queues
>
> nvme/071-073 need write and poll queues and only run for tcp and rdma.
> Without the kernel series all four fail and nvme/073 crashes the kernel,
> with the series they pass. Tested with loop and tcp.
>
> Patch 1 stops _nvme_disconnect_ctrl() and _nvme_disconnect_subsys() from
> truncating $FULL, which dropped everything logged before the disconnect,
> e.g. the fio command lines.
Daniel, thank you for the series. I ran the added test cases, and they work as
expected. With 7.3-rc7 kernel, they failed or hanged. With the kernel fix
series, they all passed.
The first patch in this series is not required because the blktests commit
64cce9a87099 already fixed the problem. Other than that, the patches overall
look good to me. I think left works for this series are as follows:
1) wait for the kernel side fixes applied,
2) modify blktests side commit messages and test script comments to reflect
the kernel side git hashes, and,
3) renumber the test cases
prev parent reply other threads:[~2026-10-20 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 7:51 [PATCH blktests 0/5] nvme: tests for isolated CPUs and fabrics queue mapping Daniel Wagner
2026-10-14 7:51 ` [PATCH blktests 1/5] common/nvme: don't truncate the full log when disconnecting Daniel Wagner
2026-10-14 7:51 ` [PATCH blktests 2/5] nvme/070: test connect with an isolated CPU Daniel Wagner
2026-10-14 7:51 ` [PATCH blktests 3/5] nvme/071: test I/O queue limits per queue type Daniel Wagner
2026-10-14 7:51 ` [PATCH blktests 4/5] nvme/072: test poll support without poll queues Daniel Wagner
2026-10-14 7:51 ` [PATCH blktests 5/5] nvme/073: test reconnect with fewer I/O queues Daniel Wagner
2026-10-20 6:40 ` Shin'ichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atcLN4XXfNF1YSZa@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox