From: Phillip Potter <phil@philpotter.co.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Phillip Potter <phil@philpotter.co.uk>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] scsi: core: update cdrom.h coments
Date: Fri, 23 Oct 2026 22:16:50 +0100 [thread overview]
Message-ID: <atvOwu-F8b4ajNOD@equinox> (raw)
In-Reply-To: <20261020170603.3692218-1-rdunlap@infradead.org>
On Tue, Oct 20, 2026 at 10:06:03AM -0700, Randy Dunlap wrote:
> Update the location and ending value of the cdrom ioctls.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: "Martin K. Petersen" <mkp@kernel.org>
> Cc: Phillip Potter <phil@philpotter.co.uk>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
>
> include/scsi/scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20261019.orig/include/scsi/scsi.h
> +++ linux-next-20261019/include/scsi/scsi.h
> @@ -176,7 +176,7 @@ enum scsi_qc_status {
> /*
> * Here are some scsi specific ioctl commands which are sometimes useful.
> *
> - * Note that include/linux/cdrom.h also defines IOCTL 0x5300 - 0x5395
> + * Note that include/uapi/linux/cdrom.h also defines IOCTL 0x5300 - 0x5396.
> */
>
> /* Used to obtain PUN and LUN info. Conflicts with CDROMAUDIOBUFSIZ */
Hi Randy,
Thanks for the patch. That said, without meaning to be too picky,
strictly speaking the quoted UAPI header file actually defines from
0x5301 onwards unless I'm missing something - perhaps we should change
the start of the range as well? Happy to adjust and forward on with your
other patch if you're happy with that?
Regards,
Phil
next prev parent reply other threads:[~2026-10-23 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 17:06 [PATCH] scsi: core: update cdrom.h coments Randy Dunlap
2026-10-23 21:16 ` Phillip Potter [this message]
2026-10-24 2:58 ` Martin K. Petersen
2026-10-29 2:02 ` Martin K. Petersen (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atvOwu-F8b4ajNOD@equinox \
--to=phil@philpotter.co.uk \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox