Linux block layer
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Tal Zussman <tz2294@columbia.edu>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	 John Garry <john.garry@linux.dev>
Subject: Re: [PATCH blktests v3 0/4] blktests: tests for the direct I/O fallback, splice, bio trimming, and atomic write fixes
Date: Tue, 27 Oct 2026 16:42:58 +0900	[thread overview]
Message-ID: <auBU8E_ZpqqApgkG@shinmob> (raw)
In-Reply-To: <20261015-blkdev-fixes-tests-v3-0-b6ffa6410514@columbia.edu>

On Oct 15, 2026 / 12:29, Tal Zussman wrote:
> Four regression tests for block device fixes under review [1],
> following block/048 for the first patch of that series.
> 
> block/050 races partial O_DIRECT writes, which finish through the
> direct I/O write fallback, against BLKBSZSET. block/051 does the same
> with splice(). Both need CONFIG_DEBUG_VM to report the folio order
> mismatch, and skip on kernels without a 64K block size or with 64K
> pages.
> 
> block/052 issues trimmed O_DIRECT writes from a hugetlb mapping to a
> device with a 64K logical block size and checks that no huge pages
> leak, covering both the dropped and the shrunk bvec.
> 
> block/053 issues a RWF_ATOMIC write from a buffer whose last page
> cannot be pinned to a scsi_debug device with atomic_wr=1 and checks
> that the device holds all of the new data or none of it.
> 
> [1] https://lore.kernel.org/linux-block/20261009-blkdev-fixes-v6-0-307939c387df@columbia.edu/

Tal, thanks for the patches. I applied the first three patches. I left the
last patch to wait for your response to John's comments.

Of note is that block/050 and block/052 fail or hang with the current
block/for-next branch or Linus master branch. Another kernel side fix [*]
is required to make them pass.

[*] https://lore.kernel.org/all/20261022062513.77372-1-mzx199711@gmail.com/

      parent reply	other threads:[~2026-10-27  7:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 16:29 [PATCH blktests v3 0/4] blktests: tests for the direct I/O fallback, splice, bio trimming, and atomic write fixes Tal Zussman
2026-10-15 16:29 ` [PATCH blktests v3 1/4] block/050: add a direct I/O write fallback race test for block devices Tal Zussman
2026-10-15 16:29 ` [PATCH blktests v3 2/4] block/051: add a splice read " Tal Zussman
2026-10-15 16:29 ` [PATCH blktests v3 3/4] block/052: add a pinned page leak test for trimmed direct writes Tal Zussman
2026-10-15 16:29 ` [PATCH blktests v3 4/4] block/053: add a torn atomic write test for block devices Tal Zussman
2026-10-16  8:53   ` John Garry
2026-10-29 23:15     ` Tal Zussman
2026-10-30  2:12       ` Shin'ichiro Kawasaki
2026-10-27  7:42 ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auBU8E_ZpqqApgkG@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=hch@lst.de \
    --cc=john.garry@linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=tz2294@columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox