From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Jens Axboe <axboe@kernel.dk>
Cc: Daniel Wagner <dwagner@suse.de>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] block: Fix NULL pointer dereference in blk_mq_complete_request_remote
Date: Thu, 19 Nov 2026 09:04:38 +0530 [thread overview]
Message-ID: <av5uTrDoSEx01BT-@csail.mit.edu> (raw)
In-Reply-To: <17a2244d-010e-425d-acc7-ce8601982a10@kernel.dk>
On Wed, Nov 18, 2026 at 01:12:42PM -0700, Jens Axboe wrote:
> On 11/18/26 12:28 PM, Srivatsa S. Bhat (Microsoft) wrote:
> > Add NULL pointer validation in blk_mq_complete_request_remote() to
> > prevent kernel crashes when block drivers pass freed request structures.
>
> Please stop this nonsense.
>
Thank you for the feedback, Jens! And thanks to Hamza and Keith for
their review, which helped me understand what the pushback was about.
I've now clarified about the underlying firmware bug being fixed (in
my other reply), which I had failed to mention earlier when I reported
that the crash isn't reproducible any more. My bad - I can see how
that (unintentional) omission made it look like I'm adding a
workaround in the kernel for a bug that exists somewhere else
altogether.
Thank you!
Regards,
Srivatsa
next prev parent reply other threads:[~2026-11-19 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 19:28 [PATCH] block: Fix NULL pointer dereference in blk_mq_complete_request_remote Srivatsa S. Bhat (Microsoft)
2026-11-18 20:12 ` Jens Axboe
2026-11-19 3:34 ` Srivatsa S. Bhat [this message]
2026-11-18 20:53 ` Hamza Mahfooz
2026-11-18 21:43 ` Keith Busch
2026-11-19 3:29 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av5uTrDoSEx01BT-@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox