From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.175 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794289020; b=NntVCeMU9AXUOUaTvJUu/Mex2A9VhZ2iFRxm3gWukBBZT4yQzuzXxMq42XshCzb2Bl7y qw0X7GafSrCmjntgT1HpXD+Ytgfo5M81dho4uD0FZ/ME8vqu1WSxUesj51tfNejSa5J43 Ze3n/BAFErtFIuwl2vS+ZClI0sWGj9xUJyLMB7U1jyyzSI+jdoBjhRLuQAe5nLme2uc1m sZFoDTGSHRKlhU/FQZE/KH/NvYs99nGArJHFIox214RqOnWJQMGJc535Q5Rc4fnYXbvsl FMdtjnhX3VGdpIaGlarLV1w1WE94fw76gudhgyNtTFBOYeL0plTchsJMiGYxBlw4/oQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794289020; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=upBQHvhIXS9jA4rn/T2U6OyiZNi8Uwc76Ij6dQGz7TA=; b=WuW8OdeowEqpcIrwyjY4/nN14JMGd5aoxL8U4kYQ/agXydoyrgu1G6yoglQ26KweF05M ZAXsNJloNdUlpu9K9hZidLU+UUOaiHO5P5OfKBRb1JARpv7XbjiYz6fDXR+VGNh8TeLmO 7rhRoVbDH1qE/snIGjZ4x9g7+yOatYUvFKWuWc8wlQpdiyJIyX70Doa6m0cQMcU4HmSb5 gKgVXftGg4IUYbt61OAjFhDToA306yQsVi+a+dOla0U1CsYmMp8r8QOu7wFBTNzo0eV2o qNdP2War5F/ApaQDtNdoQRTr95PiBsPshCLLxhiU7Dkbos+W+HR/n+AbcXMqdIXNYwg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=a20xVX7N; arc=none smtp.remote-ip=209.85.210.175 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDFD460A2623 for ; Tue, 10 Nov 2026 05:36:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EDFD460A2623 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=a20xVX7N Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8b3577deeb0so760832b3a.3 for ; Mon, 09 Nov 2026 21:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1794289019; x=1794893819; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=upBQHvhIXS9jA4rn/T2U6OyiZNi8Uwc76Ij6dQGz7TA=; b=a20xVX7NeZjvXNyM41dYWvLkg80id1Mtm74DkyBWYfM0GGXgLb8i1+nApuqtrL8uLo zE4qrJ3gNwkeUVWkpUNiFHGrdIzZeRo9Bur+lQwMh5IboV/ahqD2hnLAdr9gSwVdEq52 47ewJ4dnUp54hAJDfsvJlQHVaRbFtqFrQtWkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794289019; x=1794893819; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=upBQHvhIXS9jA4rn/T2U6OyiZNi8Uwc76Ij6dQGz7TA=; b=M/tf5dKWQWXhvBNDp0g7zjGoMR0yTMLl/anOVLnPJZN8EZCIWUgWYqZ1oYMDFawEVj URLHrA0Hw6bVWP5vN4+VBX4rcLx0AdrqUR8PGsG2349A96XqosaTEAFeqb7aBYyIJGFr kRg+jGom0I1btSm4siLOSuWAB0nSHjdfVf9qC3dWGBl/LqMj//47iussGgfKRXXgi8zX NdAsVOJrXyPrEeQYn2ioGEuNoZAcwpQM9ALIcttTypnn4R9yf965S0BlYW5ftGK5Vx2o KB4TAJo15nzwRMqCoZnlj5jqma3oqLX8Hqy1iobhn5lNnDLr8Nl0I8f7u6H3PVdgPA80 jGnA== X-Forwarded-Encrypted: i=1; AL+hErEMmUNtyWa9uJ0HwzYBKAlbo1tY82YR/dDUjA/Yq25uslmk9umYAm073rVorS0eusMIp4AUHhUn74MVqg==@vger.kernel.org X-Gm-Message-State: APuU4Z+9lMpyuZWk7J7zGSPuPAjYTWWbe1PijF7yuahU+6A/bRi50spD YjxOdfi/tEed5xpQK/6URdMRdTOg60hQjuJMOluDal/q0CETP/amg8X10ge0VQWTWw== X-Gm-Gg: AYBFou0w26bo3xmeOVtXAoQ2/aZJPN65+WGMH07OqFutN8S+ie4O6i4q2wQjqYQNdCi cl7oWlC/KEcZpMxHIpKV+Xat+v/2vLg4tsB2cVjwHUK9XkgX/U3iIpe8rB+T8V6359R9Gqyv5h6 LBjJGKzPTeyufksxViP6/BcdNRgUgpJrTyJRxMvQ00kIs3GalkAK/n7VNuM3lx2CsXZoiTzngUU P7EXaWYxijgAlhjcU6KVl8WGbxeXKRuhMzw/RyI3lY1mY//Ge0dhkWKXVgPkbRjc+3O1udJKHw/ +crS7j4Ei5zQEcTgFZDVVt/mTdhuB/JC1BqW9pHKEJiKXGA1LXhoLQLcVW6Ni2Tb4BIC3ycytxI LqrrnVpKCWD00J8/2BoqKydmtpfWP1KreSQfwMJjIAeDvb88F1CaiEw6HgSnXhFyRLgAFXzdYhW 8ziJoHNRAOZy6Iw2K40H3bMSMrMt9o3WMJIecxBNlFX+i+uDxxNfqqWrA9SfctY8efVI/wNZRT8 GZq9lrDM7FTFZzESxsOXcl0LIiCCJGmSUC+VUaaML4yNFjsotMGKdvX65BN5ChRdssc9cZUVl5O rfSUAm8FFu/MPvOE37MI3ZSf5YyX+VDqUn4s+1Atj9kH1V9DewNDlf3SsHeps/96/Y9oAQ== X-Received: by 2002:a05:6a00:1492:b0:89f:5c84:46ec with SMTP id d2e1a72fcca58-8ba89661da0mr1558178b3a.40.1794289019108; Mon, 09 Nov 2026 21:36:59 -0800 (PST) Received: from google.com ([2a00:79e0:2031:6:e137:9384:7cd8:6e40]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8baab8dccc7sm405355b3a.52.2026.11.09.21.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 21:36:58 -0800 (PST) Date: Tue, 10 Nov 2026 14:36:48 +0900 From: Sergey Senozhatsky To: Michal Wilczynski Cc: Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Minchan Kim , Sergey Senozhatsky , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, Yann Collet , Nick Terrell , Gao Xiang , Chao Yu , Jaegeuk Kim , Eric Biggers , Herbert Xu , David Laight , Sungguk , Jaehoon Chung , Marek Szyprowski , linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 10/15] lib/lz4: switch the compressor to the vendored sources Message-ID: References: <20261106-lz4-vendor-upstream-v2-0-ee04c3f0d7dc@samsung.com> <20261106-lz4-vendor-upstream-v2-10-ee04c3f0d7dc@samsung.com> X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261106-lz4-vendor-upstream-v2-10-ee04c3f0d7dc@samsung.com> On (26/11/06 15:42), Michal Wilczynski wrote: [..] > diff --git a/drivers/block/zram/backend_lz4.c b/drivers/block/zram/backend_lz4.c > index 1e4ad31d39a63f45b3bddd3d8a467d8d7d095beb..50265e3ce256490994cb6dae32a45da376e408e0 100644 > --- a/drivers/block/zram/backend_lz4.c > +++ b/drivers/block/zram/backend_lz4.c > @@ -42,7 +42,7 @@ static int lz4_setup_params(struct zcomp_params *params) > if (!params->dict || !params->dict_sz) > return 0; > > - dict_stream = kzalloc_obj(*dict_stream); > + dict_stream = kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL); > if (!dict_stream) > return -ENOMEM; > > @@ -88,7 +88,7 @@ static int lz4_create(struct zcomp_params *params, struct zcomp_ctx *ctx) > if (!zctx->dstrm) > goto error; > > - zctx->cstrm = kzalloc_obj(*zctx->cstrm); > + zctx->cstrm = kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL); > if (!zctx->cstrm) > goto error; > } > @@ -112,7 +112,7 @@ static int lz4_compress(struct zcomp_params *params, struct zcomp_ctx *ctx, > zctx->mem); > } else { > /* Cstrm needs to be reset */ > - memcpy(zctx->cstrm, params->drv_data, sizeof(*zctx->cstrm)); > + memcpy(zctx->cstrm, params->drv_data, LZ4_MEM_COMPRESS); > ret = LZ4_compress_fast_continue(zctx->cstrm, req->src, > req->dst, req->src_len, > req->dst_len, params->level); The zram code here is outdated, it has been reworked quite a bit (patches are in linux-next and Andrew's trees).