linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH blktests v2 0/6] nvme: tests for fabrics queue mapping and isolated or offline CPUs
Date: Wed, 11 Nov 2026 12:48:51 +0900	[thread overview]
Message-ID: <avPchJ4rj-xrgH4G@shinmob> (raw)
In-Reply-To: <20261104-nvme-isolcpu-v2-0-2d59f622a2c8@suse.de>

On Nov 04, 2026 / 15:25, Daniel Wagner wrote:
> Connecting an NVMe over Fabrics controller fails or crashes the kernel
> in several cases in current upstream. These tests reproduce each case
> and verify the fix.
> 
> Queue mapping bugs, fixed in mainline:
> 
>   nvme/076  More write and poll queues than online CPUs requested. A
>             queue type got more hardware contexts than online CPUs, a
>             hardware context without CPU failed its Connect command with
>             -EXDEV. Fixed by 99fd0cbae849 ("nvme-fabrics: limit each
>             queue type to the number of online CPUs").
>   nvme/077  No queues left for polling. The poll map kept the default
>             mapping, the queue claimed poll support and polled I/O went
>             to a queue which isn't a poll queue. Fixed by 36ede1aa85d5
>             ("nvme-fabrics: clear the poll map if no poll queues are
>             mapped").
>   nvme/078  Reconnect with fewer I/O queues. Stale io_queues entries
>             mapped the poll queues beyond the hardware contexts and
>             blk_mq_map_swqueue crashed. Fixed by 9588769af5fc
>             ("nvme-fabrics: reset io_queues before computing the queue
>             mapping") and 36ede1aa85d5.

Daniel, thanks for the v2 patch. I applied the first three patches for
the test cases above. Please note that I renumbered them to nvme/078-080.

The other three patches look good. IIUC, they depend on another kernel patch
[*]. I would like to wait for it applied, then take another look on them.

[*] https://lore.kernel.org/linux-block/20261104-nvme-fabrics-isolcpu-v3-1-41953b5dfba0@suse.de/

  parent reply	other threads:[~2026-11-11  3:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 14:25 [PATCH blktests v2 0/6] nvme: tests for fabrics queue mapping and isolated or offline CPUs Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 1/6] nvme/076: test I/O queue limits per queue type Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 2/6] nvme/077: test poll support without poll queues Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 3/6] nvme/078: test reconnect with fewer I/O queues Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 4/6] nvme/rc: add helpers to count the commands on a queue Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 5/6] nvme/079: test connect with an isolated CPU Daniel Wagner
2026-11-04 14:25 ` [PATCH blktests v2 6/6] nvme/080: test connect with offline CPUs Daniel Wagner
2026-11-11  3:48 ` Shin'ichiro Kawasaki [this message]
2026-11-12  9:07   ` [PATCH blktests v2 0/6] nvme: tests for fabrics queue mapping and isolated or " Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avPchJ4rj-xrgH4G@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).