Linux block layer
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 Sergey Senozhatsky <senozhatsky@chromium.org>,
	Jens Axboe <axboe@kernel.dk>, raoxu <raoxu@uniontech.com>,
	 minchan@kernel.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] zram: Avoid duplicate slots in batched writeback
Date: Sat, 14 Nov 2026 11:41:39 +0900	[thread overview]
Message-ID: <avfJOxrS2l-f5ZA3@google.com> (raw)
In-Reply-To: <1707907e-2261-4d3b-87fb-3dfc662e0347@kernel.org>

On (26/11/13 10:50), David Hildenbrand (Arm) wrote:
> > I grabbed it.
> > 
> > I did recently attempt to pull zram out of the mm project, by moving it
> > from mm.git's mm-unstable branch and into mm.git's mm-nonmm-unstable
> > branch.  Because "why does the mm project contain a block device
> > driver".
> > 
> > I undid that change after about a week - it didn't work out because
> > zram is joined at the hip with mm/zsmalloc.c.  zsmalloc is also used by
> > mm/zswap.c.
> 
> Are there cleaner ways of isolating both things?
> 
> Like, many drivers use kmalloc() etc, and they are not part of core-mm :)

This dev cycle is a little unusual, because on the zsmalloc side we
removed that "kmalloc()" [1] (along with other exported symbols that
both zram and zswap use), introduced new "kmalloc" API and this
happened atop of a very large and intrusive zram rework [2].

We don't change zsmalloc exported API too often, but it happens,
sometimes.

[1] https://lore.kernel.org/lkml/20261111064707.2568433-1-senozhatsky@chromium.org/
[2] https://lore.kernel.org/linux-kernel/20261025021839.1542805-1-senozhatsky@chromium.org

      reply	other threads:[~2026-11-14  2:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  6:18 [PATCH] zram: Avoid duplicate slots in batched writeback raoxu
2026-11-10  6:40 ` Sergey Senozhatsky
2026-11-13  7:26   ` Andrew Morton
2026-11-13  9:50     ` David Hildenbrand (Arm)
2026-11-14  2:41       ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avfJOxrS2l-f5ZA3@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=david@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=raoxu@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox