linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Jesse Taube <jtaubepe@redhat.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	 John Meneghini <jmeneghi@redhat.com>,
	Daniel Wagner <dwagner@suse.de>,
	kbusch@kernel.org,  kch@nvidia.com, hch@lst.de, sagi@grimberg.me,
	 "Ewan D . Milne" <emilne@redhat.com>,
	"Claude Opus 4.6" <noreply@anthropic.com>
Subject: Re: [blktests] nvme/077: Add ANA log page information leak test
Date: Wed, 18 Nov 2026 10:05:54 +0900	[thread overview]
Message-ID: <avz5VW5H390JN87j@shinmob> (raw)
In-Reply-To: <CADRr4bdwGdeQsH5Rwhzd0HjRYDuPopK5_6SLi7BKnpg=XOLpbA@mail.gmail.com>

On Nov 16, 2026 / 11:13, Jesse Taube wrote:
> On Thu, Nov 12, 2026 at 5:36 AM Shin'ichiro Kawasaki
> <shinichiro.kawasaki@wdc.com> wrote:
> >
> > On Nov 04, 2026 / 12:38, Jesse Taube wrote:
> > > Regression test for reading memory contents beyond valid data when
> > > reading ANA log page. The NVMe target must zero-fill the ANA log page
> > > response buffer beyond the valid data so that stale kernel memory is
> > > not leaked to the host.
> > >
> > > The helper program (nvme-ana-log), requests the ANA log page,
> > > parses the response header to find where valid data ends, and checks
> > > that every trailing byte is zero. The check is repeated 64 times because
> > > leaked data may incidentally be zeroed.
> > >
> > > Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
> > > Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> > > ---
> > > This test is meant to test:
> > > Lore Link: https://lore.kernel.org/linux-nvme/20261104172833.161567-1-emilne@redhat.com/
> >
> > Thank you for the patch. I ran the new test case on the v7.4-rc2 kernel and
> > confirmed it passes. When I reverted the kernel commit 29b8758b470 (" nvmet:
> > don't return memory contents beyond valid data when reading ANA log page"),
> > the test case failed. Looks working well.
> >
> > Overall, this blktests patch looks good. I have three minor comments below:
> >
> >  1) src/.gitignore should have "/nvme-ana-log".
> >  2) it's the better to note about the kernel commit in the commit log and
> >     the test case comment
> >  3) I think "--port 0" option of _nvme_connect_subsys call in test() is not
> >     required
> >
> > Jesee, if you are fine, I will make ammendments based on the comments above
> > and apply this patch. Or you can respin the patch. Please let me know your
> > preference.
> 
> Sorry I seem to have missed this. Yes it would be great if you could
> make those fixes.
> It will be faster than resubmitting and waiting for a review again.

Okay, I have merged it. Now the test case has the number nvme/080. Thanks!

Of note is that I also dropped the tag "Co-Authored-By: Claude Opus 4.6
<noreply@anthropic.com>" because a mail to the e-mail address was not delivered
properly.

      reply	other threads:[~2026-11-18  1:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 17:38 [blktests] nvme/077: Add ANA log page information leak test Jesse Taube
2026-11-12 10:36 ` Shin'ichiro Kawasaki
2026-11-16 16:13   ` Jesse Taube
2026-11-18  1:05     ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avz5VW5H390JN87j@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=dwagner@suse.de \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=jmeneghi@redhat.com \
    --cc=jtaubepe@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=noreply@anthropic.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).