From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.105 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795179089; b=Sjw+tyuNppQ88DSwN/3KQa6Gc8QnmIWt9hQ+VerMCYuC5tlxSk7OsyYU0o6/r1EszZkv 8fBeExyoFKsbblgoJVE6ECxnOag3K7Z+be6rrVh6f5DQkTsF7udJcN6fdWqFK2N0NdLAo IKBp/wCq0V9ma6So4NnGvS5WPrpG8AlPRfPv9UEqlDZtBlcE/zg8KbTZGT3R2hKeXUNjG MWg1WFJc45Z9WSEw9LRba2IAXLl4phSK9ZPtnSeHDixWHTgMBrTCStiB+K0b6y2jsNgQ+ LhChcYYT8pkUdg/8SAQC4oX5ZXfB/MDHRfzH7zMCZEVzwU6mdlGkHK4PdMQ+rr/1eng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795179089; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=RwK+sZmEfro4R2XrALiEL0NIpL3hInhE+mN5nJsjAK8=; b=TnuRuY/1iH/LAAj1agXE+LaMRYxXYaj5YSNngpbU+SJGkvNff8x8iRj33UnfAXCquA2y x/3uthPPZsnVOs3oTymZFTjpYeGKuJJRj7HJ8cI/S8UPcz8EeXH/FjVZghQ/KZjR50e7U 3I9XeomBt6QTf1qXhdS+sKHRNm2RN7+vLaqUlJA7a0iF35j85f4UBYlMOvsTf2JNsDvmp julqbjkhY11TSAbQkh3CjUazfRHKH1mHVEGeLP/tzc4jxQJdVzFVtmrSsgfHwWTR+OMCY FGmawkhDnIduoW8cx22J4NeV3slIMbRa2bjWsmd0Tti31eRZgu6+iqBY9QgyfGSHEWg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=CVboDCpu; arc=none smtp.remote-ip=91.218.175.105 Received: from mta0.migadu.com (out-105.mta0.migadu.com [91.218.175.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B6160A261E for ; Fri, 20 Nov 2026 12:51:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 53B6160A261E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=CVboDCpu X-Envelope-To: linux-block@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=/M71l9OR+PuswlMFy8Wbwhup3v6OafAF4YhJlLt/84U=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795179086; v=1; x=1795783886; b=CVboDCpuuv2WqQiy/vtf05zSEtSkLQsRJ/djYGgQWt91weN3dja9zelbY5vaAyy3HckRz8nB LTBIz+A0NBi0SxrULdX4yPc6ILwbmx6ofWOwOp9UzoFU9UnVUAYdYhC2d48tOPwt0UJKs6MIxos hQ8bQNPKUm99WaSVdem1tj90= X-Envelope-To: linux-block@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 624a9615c12efaf1; Fri, 20 Nov 2026 12:51:26 +0000 X-Mizu-Trace-ID: 624a9615c12efaf1 X-Migadu-Flow: FLOW_OUT Date: Fri, 20 Nov 2026 13:51:14 +0100 From: "Pankaj Raghav (Samsung)" To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Andreas Gruenbacher , gfs2@lists.linux.dev, Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Carlos Maiolino , linux-xfs@vger.kernel.org, David Howells , Marc Dionne , linux-afs@lists.infradead.org, Miklos Szeredi , fuse-devel@lists.linux.dev, linux-block@vger.kernel.org, Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Eric Biggers , Jaegeuk Kim , linux-fscrypt@vger.kernel.org Subject: Re: [PATCH 01/13] bdev: Drop pointless loop from blkdev_flush_mapping() Message-ID: References: <20261116171044.6938-1-jack@suse.cz> <20261118145941.1063127-14-jack@suse.cz> X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261118145941.1063127-14-jack@suse.cz> On Wed, Nov 18, 2026 at 03:59:35PM +0100, Jan Kara wrote: > bdev_write_inode() is really odd loop calling write_inode_now(). The > bdev doesn't have any pages by now and if there are any dirty bits in > the inode state, they are stale. Just call write_inode_now() once to > clear them. > > Signed-off-by: Jan Kara When I looked at the commit that introduced bdev_write_inode()[1], it says to call write_inode_now() on the final put of the block device. At the moment, tt looks like we call bdev_write_inode() only when bd_openers is 0. Looks good, Reviewed-by: Pankaj Raghav (Samsung) -- Pankaj [1] 564f00f6c03a ("block_dev: only write bdev inode on close") > --- > block/bdev.c | 25 ++++++------------------- > 1 file changed, 6 insertions(+), 19 deletions(-) > > diff --git a/block/bdev.c b/block/bdev.c > index f20f91b3176e..9fa72df4f47a 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -60,24 +60,6 @@ struct block_device *file_bdev(struct file *bdev_file) > } > EXPORT_SYMBOL(file_bdev); > > -static void bdev_write_inode(struct block_device *bdev) > -{ > - struct inode *inode = BD_INODE(bdev); > - int ret; > - > - spin_lock(&inode->i_lock); > - while (inode_state_read(inode) & I_DIRTY) { > - spin_unlock(&inode->i_lock); > - ret = write_inode_now(inode, true); > - if (ret) > - pr_warn_ratelimited( > - "VFS: Dirty inode writeback failed for block device %pg (err=%d).\n", > - bdev, ret); > - spin_lock(&inode->i_lock); > - } > - spin_unlock(&inode->i_lock); > -} > - > /* Kill _all_ buffers and pagecache , dirty or not.. */ > static void kill_bdev(struct block_device *bdev) > { > @@ -755,7 +737,12 @@ static void blkdev_flush_mapping(struct block_device *bdev) > WARN_ON_ONCE(bdev->bd_holders); > sync_blockdev(bdev); > kill_bdev(bdev); > - bdev_write_inode(bdev); > + /* > + * All data is written out and evicted but inode can have some stale > + * I_DIRTY bits set. Call write_inode_now() to get rid of them so that > + * the inode can be evicted. > + */ > + write_inode_now(BD_INODE(bdev), 1); > } > > static void blkdev_put_whole(struct block_device *bdev) > -- > 2.53.0 >