From: Christoph Hellwig <hch@infradead.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/t10-pi: deduplicate blk_reftag_remap_{prepare,complete}()
Date: Fri, 20 Nov 2026 16:18:12 -0800 [thread overview]
Message-ID: <awDjRMv-TSvZKDdS@infradead.org> (raw)
In-Reply-To: <CADUfDZonvcOkM7DD76Gg=Z6NHhM87a+n0xPirfTYS+wLLnHfmQ@mail.gmail.com>
On Fri, Nov 20, 2026 at 10:29:18AM -0800, Caleb Sander Mateos wrote:
> Sure, happy to switch to an if statement instead of the ternaries to
> initialize from and to. However, the code generation is worse with the
> 2 calls to blk_reftag_remap()/blk_tuple_remap(). The compiler doesn't
> notice that the calls are identical except for the swapped arguments
> and emits 2 out-of-line calls to the function instead of inlining it.
Add a __force_inline tag to blk_tuple_remap and see if that fixes it?
prev parent reply other threads:[~2026-11-21 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:48 [PATCH] block/t10-pi: deduplicate blk_reftag_remap_{prepare,complete}() Caleb Sander Mateos
2026-11-20 16:00 ` Christoph Hellwig
2026-11-20 18:29 ` Caleb Sander Mateos
2026-11-21 0:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awDjRMv-TSvZKDdS@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox