Re: [PATCH] nvme: add nvme pci timeout testcase

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 1/9/24 22:17, Nitesh Shetty wrote:
> On 09/01/24 07:57PM, Chaitanya Kulkarni wrote:
>> Trigger and test nvme-pci timeout with concurrent fio jobs.
>>
>> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
>> ---
>> tests/nvme/050     | 43 +++++++++++++++++++++++++++++++++++++++++++
>> tests/nvme/050.out |  2 ++
>> 2 files changed, 45 insertions(+)
>> create mode 100755 tests/nvme/050
>> create mode 100644 tests/nvme/050.out
>>
>> diff --git a/tests/nvme/050 b/tests/nvme/050
>> new file mode 100755
>> index 0000000..ba54bcd
>> --- /dev/null
>> +++ b/tests/nvme/050
>> @@ -0,0 +1,43 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Copyright (C) 2024 Chaitanya Kulkarni.
>> +#
>> +# Test NVMe-PCI timeout with FIO jobs by triggering the nvme_timeout 
>> function.
>> +#
>> +
>> +. tests/nvme/rc
>> +
>> +DESCRIPTION="test nvme-pci timeout with fio jobs."
>> +
>> +requires() {
>> +    _require_nvme_trtype pci
>> +    _have_fio
>> +    _nvme_requires
>> +}
>> +
>> +test() {
>> +    local dev="/dev/nvme0n1"
>
> Should this be TEST_DEV instead ?

why ?

>
>
>> +
>> +    echo "Running ${TEST_NAME}"
>> +
>> +    echo 1 > /sys/block/nvme0n1/io-timeout-fail
>
> nvme0n1, I think this hard coding can be changed
>

why ?

-ck