Re: ❌ FAIL: Test report for kernel 5.13.0-rc6 (block, b0740de3)

[Jens Axboe <axboe@kernel.dk>]

On 6/21/21 5:49 PM, Matthew Wilcox wrote:
> On Mon, Jun 21, 2021 at 05:42:15PM -0600, Jens Axboe wrote:
>> On 6/21/21 5:32 PM, Matthew Wilcox wrote:
>>> On Mon, Jun 21, 2021 at 11:57:06PM +0100, Pavel Begunkov wrote:
>>>> On 6/21/21 10:58 PM, Matthew Wilcox wrote:
>>>>> On Mon, Jun 21, 2021 at 11:07:16PM +0200, Veronika Kabatova wrote:
>>>>>> On Mon, Jun 21, 2021 at 11:00 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>>
>>>>>>> On 6/21/21 2:57 PM, Veronika Kabatova wrote:
>>>>>>>> On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@redhat.com> wrote:
>>>>>>>>>
>>>>>>>>> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@redhat.com> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> We ran automated tests on a recent commit from this kernel tree:
>>>>>>>>>>
>>>>>>>>>>        Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>>>>>>             Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next
>>>>>>>>>>
>>>>>>>>>> The results of these automated tests are provided below.
>>>>>>>>>>
>>>>>>>>>>     Overall result: FAILED (see details below)
>>>>>>>>>>              Merge: OK
>>>>>>>>>>            Compile: FAILED
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> the failure is introduced between this commit and d142f908ebab64955eb48e.
>>>>>>>>> Currently seeing if I can bisect it closer but maybe someone already has an
>>>>>>>>> idea what went wrong.
>>>>>>>>>
>>>>>>>>
>>>>>>>> First commit failing the compilation is 7a2b0ef2a3b83733d7.
>>>>>>>
>>>>>>> Where's the log? Adding Willy...
>>>>>>>
>>>>>>
>>>>>> Logs and kernel configs for each arch are linked in the original email at
>>>>>> https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefix=datawarehouse-public/2021/06/21/324657779
>>>>>
>>>>> Which aren't there by the time they get to the original commit author.
>>>>> You need to do better than this; the Intel build-bot bisects to the
>>>>> commit which actually causes the error.
>>>>
>>>> Matthew, I've just followed the link out of curiosity:
>>>
>>> the link _which isn't in the first email i got_.  the redhat cki system
>>> is not very useful _because it doesn't do an automatic bisect and cc the
>>> author of the commit_.
>>
>> Kinks are still being worked out on that, nobody has claimed it's
>> perfect yet. Some manual input/labor is still required.
>>
>> But it's useful, as this report has indicated. So maybe try and be a bit
>> nicer and appreciative, instead of grumpy and dismissive. It did find a
>> problem with YOUR patch, fwiw.
> 
> and i've already fixed it, and tested it with a make allmodconfig.

Which should have been done before submitting a patch like this.

> turned out to be the only missing place.
> 
> i get grumpy when people implement auto-harassing systems badly.

It's a bad look of entitlement when complaints are made about everything
not being served on a silver platter. The service has been useful to me,
and it was useful in this particular case. Can it be improved? Surely,
everything can, and this one is a bit more rough around the edges than
the intel build bot. Which, coincidentally, has been around for many
years, so hardly surprising. This one triggered quickly, the intel bot
sometimes takes _days_ to produce anything. Improvements can be made in
both cases.

And _I_ was the one that CC'ed you on the report, as it was your commit
that broke the build, not the bot. Nobody got auto-harassed here.

-- 
Jens Axboe