From: Kashyap Desai <kashyap.desai@broadcom.com>
To: John Garry <john.garry@huawei.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com, hare@suse.de
Subject: RE: [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags
Date: Thu, 25 Nov 2021 19:16:51 +0530 [thread overview]
Message-ID: <b18285f4aa0e8be796aea19cdfde0293@mail.gmail.com> (raw)
In-Reply-To: 0c3ab8737fe86c522ee4f10fd5ffc102@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 2297 bytes --]
> -----Original Message-----
> From: Kashyap Desai [mailto:kashyap.desai@broadcom.com]
> Sent: Monday, November 15, 2021 10:02 PM
> To: 'John Garry' <john.garry@huawei.com>; 'axboe@kernel.dk'
> <axboe@kernel.dk>
> Cc: 'linux-block@vger.kernel.org' <linux-block@vger.kernel.org>; 'linux-
> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
> 'ming.lei@redhat.com'
> <ming.lei@redhat.com>; 'hare@suse.de' <hare@suse.de>
> Subject: RE: [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter()
> for shared tags
>
> > Hi Kashyap,
> >
> > Any chance you can try this series or give an update on the issue
> > reported earlier?
>
> John -
>
> I will try something this week and let you know.
John - I tested patchset and looks good. Issue reported at below thread is
fixed.
https://lore.kernel.org/linux-block/e4e92abbe9d52bcba6b8cc6c91c442cc@mail.gmail.com/
Here is perf top data.
5.70% [megaraid_sas] [k] complete_cmd_fusion
3.80% [megaraid_sas] [k]
megasas_build_and_issue_cmd_fusion
2.75% [kernel] [k] syscall_return_via_sysret
2.68% [kernel] [k] entry_SYSCALL_64
2.22% [kernel] [k] io_submit_one
2.19% [megaraid_sas] [k] megasas_build_ldio_fusion
1.95% [kernel] [k] llist_add_batch
1.80% [kernel] [k] llist_reverse_order
1.79% [kernel] [k] scsi_complete
1.73% [kernel] [k] scsi_queue_rq
1.66% [kernel] [k] check_preemption_disabled
1.37% [megaraid_sas] [k] megasas_queue_command
1.16% [kernel] [k] native_irq_return_iret
1.11% [kernel] [k] aio_complete_rw
1.07% [kernel] [k] read_tsc
1.06% fio [.] __fio_gettime
1.05% [kernel] [k] flush_smp_call_function_queue
1.03% [kernel] [k] blk_complete_reqs
1.00% [kernel] [k] blk_mq_free_request
0.98% [kernel] [k] sbitmap_get
I will continue testing and let you know how it goes.
Kashyap
>
> >
> > thanks @ Ming for the reviews.
> >
> > Cheers,
> > John
> >
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-11-25 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:27 [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-11-02 11:27 ` [PATCH RFT 1/3] blk-mq: Drop busy_iter_fn blk_mq_hw_ctx argument John Garry
2021-11-09 3:02 ` Ming Lei
2021-11-28 10:39 ` Hannes Reinecke
2021-11-02 11:27 ` [PATCH RFT 2/3] blk-mq: Delete busy_iter_fn John Garry
2021-11-09 3:05 ` Ming Lei
2021-11-28 10:40 ` Hannes Reinecke
2021-11-02 11:27 ` [PATCH RFT 3/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-11-28 10:43 ` Hannes Reinecke
2021-11-29 2:19 ` Ming Lei
2021-11-15 15:56 ` [PATCH RFT 0/3] " John Garry
2021-11-15 16:31 ` Kashyap Desai
2021-11-25 13:46 ` Kashyap Desai [this message]
2021-11-25 14:09 ` John Garry
2021-11-26 11:25 ` Kashyap Desai
2021-11-26 11:51 ` John Garry
2021-12-06 9:57 ` John Garry
2021-12-06 10:03 ` Kashyap Desai
2021-12-08 13:04 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18285f4aa0e8be796aea19cdfde0293@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).