From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Nicholas A . Bellinger" <nab@linux-iscsi.org>,
Laurence Oberman <loberman@redhat.com>
Subject: Re: [PATCH] lib/scatterlist: Fix chaining support in sgl_alloc_order()
Date: Fri, 19 Jan 2018 12:31:36 -0700 [thread overview]
Message-ID: <b2309bd1-acfd-1853-bde0-c59d1a4d11a1@kernel.dk> (raw)
In-Reply-To: <20180119190054.10789-1-bart.vanassche@wdc.com>
On 1/19/18 12:00 PM, Bart Van Assche wrote:
> This patch avoids that workloads with large block sizes (megabytes)
> can trigger the following call stack with the ib_srpt driver (that
> driver is the only driver that chains scatterlists allocated by
> sgl_alloc_order()):
>
> BUG: Bad page state in process kworker/0:1H pfn:2423a78
> page:fffffb03d08e9e00 count:-3 mapcount:0 mapping: (null) index:0x0
> flags: 0x57ffffc0000000()
> raw: 0057ffffc0000000 0000000000000000 0000000000000000 fffffffdffffffff
> raw: dead000000000100 dead000000000200 0000000000000000 0000000000000000
> page dumped because: nonzero _count
> CPU: 0 PID: 733 Comm: kworker/0:1H Tainted: G I 4.15.0-rc7.bart+ #1
> Hardware name: HP ProLiant DL380 G7, BIOS P67 08/16/2015
> Workqueue: ib-comp-wq ib_cq_poll_work [ib_core]
> Call Trace:
> dump_stack+0x5c/0x83
> bad_page+0xf5/0x10f
> get_page_from_freelist+0xa46/0x11b0
> __alloc_pages_nodemask+0x103/0x290
> sgl_alloc_order+0x101/0x180
> target_alloc_sgl+0x2c/0x40 [target_core_mod]
> srpt_alloc_rw_ctxs+0x173/0x2d0 [ib_srpt]
> srpt_handle_new_iu+0x61e/0x7f0 [ib_srpt]
> __ib_process_cq+0x55/0xa0 [ib_core]
> ib_cq_poll_work+0x1b/0x60 [ib_core]
> process_one_work+0x141/0x340
> worker_thread+0x47/0x3e0
> kthread+0xf5/0x130
> ret_from_fork+0x1f/0x30
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-01-19 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 19:00 [PATCH] lib/scatterlist: Fix chaining support in sgl_alloc_order() Bart Van Assche
2018-01-19 19:06 ` Laurence Oberman
2018-01-19 19:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2309bd1-acfd-1853-bde0-c59d1a4d11a1@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox