From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
James Smart <james.smart@broadcom.com>,
Dongli Zhang <dongli.zhang@oracle.com>,
Bart Van Assche <bart.vanassche@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Subject: Re: [PATCH V9 0/7] blk-mq: fix races related with freeing queue
Date: Sat, 4 May 2019 07:24:41 -0600 [thread overview]
Message-ID: <b2472816-1994-be7c-239c-865a915567ef@kernel.dk> (raw)
In-Reply-To: <20190430015229.23141-1-ming.lei@redhat.com>
On 4/29/19 7:52 PM, Ming Lei wrote:
> Hi,
>
> Since 45a9c9d909b2 ("blk-mq: Fix a use-after-free"), run queue isn't
> allowed during cleanup queue even though queue refcount is held.
>
> This change has caused lots of kernel oops triggered in run queue path,
> turns out it isn't easy to fix them all.
>
> So move freeing of hw queue resources into hctx's release handler, then
> the above issue is fixed. Meantime, this way is safe given freeing hw
> queue resource doesn't require tags.
Applied, thanks Ming.
--
Jens Axboe
prev parent reply other threads:[~2019-05-04 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 1:52 [PATCH V9 0/7] blk-mq: fix races related with freeing queue Ming Lei
2019-04-30 1:52 ` [PATCH V9 1/7] blk-mq: grab .q_usage_counter when queuing request from plug code path Ming Lei
2019-04-30 2:15 ` Bart Van Assche
2019-04-30 1:52 ` [PATCH V9 2/7] blk-mq: move cancel of requeue_work into blk_mq_release Ming Lei
2019-04-30 1:52 ` [PATCH V9 3/7] blk-mq: free hw queue's resource in hctx's release handler Ming Lei
2019-04-30 1:52 ` [PATCH V9 4/7] blk-mq: split blk_mq_alloc_and_init_hctx into two parts Ming Lei
2019-04-30 1:52 ` [PATCH V9 5/7] blk-mq: always free hctx after request queue is freed Ming Lei
2019-04-30 1:52 ` [PATCH V9 6/7] blk-mq: move cancel of hctx->run_work into blk_mq_hw_sysfs_release Ming Lei
2019-04-30 1:52 ` [PATCH V9 7/7] block: don't drain in-progress dispatch in blk_cleanup_queue() Ming Lei
2019-05-04 13:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2472816-1994-be7c-239c-865a915567ef@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dongli.zhang@oracle.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox