public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: Support building the iocost and iolatency policies as kernel modules
Date: Wed, 6 Mar 2024 17:11:03 -0800	[thread overview]
Message-ID: <b2907ddb-6e48-4c9a-b4e7-d6239550d5c3@acm.org> (raw)
In-Reply-To: <396d15a0-eedc-bf00-dd56-c064293fcaa5@huaweicloud.com>

On 3/5/24 17:34, Yu Kuai wrote:
> Looks like there are lots of work need to be done as well, for
> exapmle:
> 
> - ping the iocost Module before enabling it for a disk, otherwise unload
> the Module will cause problems;

Hmm ... loading a block driver, loading blk-iocost, unloading the block
driver and unloading blk-iocost works fine on my test setup.

> - free the iocost structure after disabling it, otherwise iocost Module
> can never be unloaded;

I will check whether struct ioc is freed when unloading blk-iocost.

Thanks,

Bart.

  reply	other threads:[~2024-03-07  1:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  0:39 [PATCH] block: Support building the iocost and iolatency policies as kernel modules Bart Van Assche
2024-03-06  1:34 ` Yu Kuai
2024-03-07  1:11   ` Bart Van Assche [this message]
2024-03-07  1:15     ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2907ddb-6e48-4c9a-b4e7-d6239550d5c3@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox