From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] cdrom: information leak in cdrom_ioctl_media_changed()
Date: Wed, 18 Apr 2018 08:21:44 -0600 [thread overview]
Message-ID: <b2f8739b-d93d-e89c-ec70-a96299f47a0c@kernel.dk> (raw)
In-Reply-To: <20180418095130.GA26904@mwanda>
On 4/18/18 3:51 AM, Dan Carpenter wrote:
> This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned
> long. The way the check is written now, if one of the high 32 bits is
> set then we could read outside the info->slots[] array.
>
> This bug is pretty old and it predates git.
Thanks Dan, applied.
--
Jens Axboe
next prev parent reply other threads:[~2018-04-18 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 9:51 [PATCH] cdrom: information leak in cdrom_ioctl_media_changed() Dan Carpenter
2018-04-18 10:35 ` Christoph Hellwig
2018-04-18 14:21 ` Jens Axboe [this message]
2018-04-25 17:37 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f8739b-d93d-e89c-ec70-a96299f47a0c@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox