From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: reorder the REQ_ flags
Date: Wed, 11 May 2022 07:31:47 +0000 [thread overview]
Message-ID: <b35e786e-3e38-ce08-efca-912b33c248d6@nvidia.com> (raw)
In-Reply-To: <09a72de2-c171-63d8-ff0d-13050aa40c87@kernel.dk>
On 5/10/2022 4:03 PM, Jens Axboe wrote:
> On 5/10/22 7:00 AM, Christoph Hellwig wrote:
>> Keep the op-specific flag last.
>
> Not that I'm against the patch, but we really should have some
> justification in the commit message as to why the change is
> useful or needed.
>
Something like following might be useful :-
"Currently we support seven request flags out of which only
__REQ_NOUNMAP is used with REQ_OP_WRITE_ZEROES, rest of the flags are
not necessarily associated with specific REQ_OP_XXX. Instead of mixing
the request specific flags with the non-request specific flags, move
request specific flags __REQ_NOUNMAP at the end for better readability
so future request specific flags can go at the end."
Full disclosure I've not verified other flags.
-ck
prev parent reply other threads:[~2022-05-11 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 13:00 [PATCH] block: reorder the REQ_ flags Christoph Hellwig
2022-05-10 23:03 ` Jens Axboe
2022-05-11 7:31 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35e786e-3e38-ce08-efca-912b33c248d6@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox