From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE50112B82; Thu, 4 Apr 2024 17:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712250883; cv=none; b=t9Bve7bMOzEVj0q0diVu+lPHaNfhARwCZ7022y+y9bRnLw4Rv+dh0pEQB8vePhTqcuqaLctDfUSR/y/82xocNl5BsUc+1VQH3LZhlGSV0F+W32y+jsw/wCBwj9TgxklT0eG7irKA6vZl8C9/IImfC4u3Yi96C2+bbei5pSEAMMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712250883; c=relaxed/simple; bh=0ThKWEb5Va9lCoiyDiwM4Fd3MTLd1O5J3WXqdVyM5uY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=owncQIDdPTvBMm/xpf+4OpBHsd3QyvHO0QEsM/iM8AOCF9iAvHDzNHBPGUc/OIsqqFTX4YpAPbuLH/I6vx0N0+5dvwZEWho8qRw8UjEBlup/TpjzVIxXGyxP/4Pg+sTLZsTDNmBzq3nd/+1W/YyuMvFo+dt5DpzM8UReC5Qab/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=4elaLUQp; arc=none smtp.client-ip=199.89.1.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="4elaLUQp" Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4V9SsY12nqzlgTGW; Thu, 4 Apr 2024 17:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:content-language:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1712250871; x=1714842872; bh=jr0JFFiQtpqpO8gPLnOaQNi8 PjSCGPDkwB+DlLUzoY4=; b=4elaLUQp4IMwetRsTHRLmmo0zrN6Qp0hf96RHuIC Mz/BqirWSarCcj8tGDWEKQ46bNPHfIb5XvGkBpH2aB0fYIsi7N16IcqDs8Kp+yxI 4uAlF0lO1cPfoDoZoBfFBUSzttViTbttepvVHGi9N+6wBCwvyb69cr58l49dFYmX WxnJIV9hf4Q3iEn+QaxTfZeO3gRUHjEdScAU3KM4KKREvi49BagTI5dXgh3F3sWy hB+Ftmv+Z1Roq1Zv8kv9lt/0iC2nA2INrgSIpaQmclVS6mGXO9v1PsEDkPPpbUSc WemTiq2m1eGAKTGQXFvVvsuKZLuBiac8Lx1XdXCGNkb9/A== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id CLtdbJxEdr2m; Thu, 4 Apr 2024 17:14:31 +0000 (UTC) Received: from [100.96.154.173] (unknown [104.132.1.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4V9SsH0BryzlgTHp; Thu, 4 Apr 2024 17:14:26 +0000 (UTC) Message-ID: Date: Thu, 4 Apr 2024 10:14:26 -0700 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/23] scsi: add a device_configure method to the host template Content-Language: en-US To: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" Cc: Damien Le Moal , Niklas Cassel , Takashi Sakamoto , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "Juergen E. Fischer" , Xiang Chen , HighPoint Linux Team , Tyrel Datwyler , Brian King , Lee Duncan , Chris Leech , Mike Christie , John Garry , Jason Yan , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Jack Wang , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Greg Kroah-Hartman , Alim Akhtar , Avri Altman , Krzysztof Kozlowski , Alan Stern , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux1394-devel@lists.sourceforge.net, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20240402130645.653507-1-hch@lst.de> <20240402130645.653507-11-hch@lst.de> From: Bart Van Assche In-Reply-To: <20240402130645.653507-11-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/2/24 06:06, Christoph Hellwig wrote: > This is a version of ->slave_configure that also takes a queue_limits > structure that the caller applies, and thus allows drivers to reconfigure > the queue using the atomic queue limits API. > > In the long run it should also replace ->slave_configure entirely as > there is no need to have two different methods here, and the slave > name in addition to being politically charged also has no basis in > the SCSI standards or the kernel code. Reviewed-by: Bart Van Assche