From: Jens Axboe <axboe@kernel.dk>
To: Hou Pu <houpu.main@gmail.com>, josef@toxicpanda.com, mchristi@redhat.com
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
Hou Pu <houpu@bytedance.com>
Subject: Re: [PATCH v2 0/2] nbd: requeue request if only one connection is configured
Date: Thu, 12 Mar 2020 07:59:01 -0600 [thread overview]
Message-ID: <b407f0d1-f07c-4d6b-9657-bb296557ff50@kernel.dk> (raw)
In-Reply-To: <20200228064030.16780-1-houpu@bytedance.com>
On 2/27/20 11:40 PM, Hou Pu wrote:
> Hello,
>
> NBD server could be upgraded if we have multiple connections.
> But if we have only one connection, after we take down NBD server,
> all inflight IO could finally timeout and return error. These
> patches fix this using current reconfiguration framework.
>
> I noticed that Mike has following patchset
>
> nbd: local daemon restart support
> https://lore.kernel.org/linux-block/5DD41C49.3080209@redhat.com/
>
> It add another netlink interface (NBD_ATTR_SWAP_SOCKETS) and requeue
> request immediately after recongirure/swap socket. It do not need to
> wait for timeout to fire and requeue in timeout handler, which seems more
> like an improvement. Let fix this in current framework first.
>
> Changes compared to v2:
> Fix comments in nbd_read_stat() to be aligned with the code change
> suggested by Mike Christie.
Applied for 5.7.
--
Jens Axboe
next prev parent reply other threads:[~2020-03-12 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 6:40 [PATCH v2 0/2] nbd: requeue request if only one connection is configured Hou Pu
2020-02-28 6:40 ` [PATCH 1/2] nbd: enable replace socket " Hou Pu
2020-03-03 21:12 ` Josef Bacik
2020-03-03 21:48 ` Mike Christie
2020-03-04 5:41 ` Hou Pu
2020-03-04 18:48 ` Josef Bacik
2020-02-28 6:40 ` [PATCH 2/2] nbd: requeue command if the soecket is changed Hou Pu
2020-03-03 21:13 ` Josef Bacik
2020-03-03 22:06 ` Mike Christie
2020-03-03 22:21 ` Mike Christie
2020-03-04 7:13 ` Hou Pu
2020-03-04 18:48 ` Josef Bacik
2020-03-12 13:59 ` Jens Axboe [this message]
2020-03-13 11:29 ` [PATCH v2 0/2] nbd: requeue request if only one connection is configured Hou Pu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b407f0d1-f07c-4d6b-9657-bb296557ff50@kernel.dk \
--to=axboe@kernel.dk \
--cc=houpu.main@gmail.com \
--cc=houpu@bytedance.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox