From: Bart Van Assche <bvanassche@acm.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>,
"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"vincent.fu@samsung.com" <vincent.fu@samsung.com>,
"yukuai3@huawei.com" <yukuai3@huawei.com>
Subject: Re: [PATCH] null_blk: allow teardown on request timeout
Date: Wed, 19 Oct 2022 10:41:18 -0700 [thread overview]
Message-ID: <b49d7e9b-fdee-915a-436a-bb624addf9a2@acm.org> (raw)
In-Reply-To: <d3e05b4e-466b-844c-b815-79233856e527@nvidia.com>
On 10/18/22 21:19, Chaitanya Kulkarni wrote:
> Also, I've listed the problem that I've seen first hand for keeping the
> device in the system that is non-responsive due to request timeouts, in
> that case we should let user decide whether user wants to remove or keep
> the device in the system instead of forcing user to keep the device in
> the system bringing down whole system, and these problems are really
> hard to debug even with Teledyne LeCroy [1]. This patch follows the same
> philosophy where user can decide to opt in for removal with module
> parameter. Once opt-in user knows what he is getting into.
Hi Chaitanya,
From commit f2298c0403b0 ("null_blk: multi queue aware block test
driver"): "Written to facilitate testing of the blk-mq code". I'm not
sure of this but adding a mechanism like the one in this patch may fall
outside the original scope of the null_blk driver.
Thanks,
Bart.
next prev parent reply other threads:[~2022-10-19 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 5:20 [PATCH] null_blk: allow teardown on request timeout Chaitanya Kulkarni
2022-10-17 1:26 ` Damien Le Moal
2022-10-17 8:42 ` Chaitanya Kulkarni
2022-10-17 9:25 ` Ming Lei
2022-10-17 9:30 ` Chaitanya Kulkarni
2022-10-17 9:50 ` Ming Lei
2022-10-17 10:04 ` Chaitanya Kulkarni
2022-10-17 10:16 ` Ming Lei
2022-10-17 10:46 ` Chaitanya Kulkarni
2022-10-17 14:21 ` Bart Van Assche
2022-10-19 4:19 ` Chaitanya Kulkarni
2022-10-19 17:41 ` Bart Van Assche [this message]
2022-11-02 1:09 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b49d7e9b-fdee-915a-436a-bb624addf9a2@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox