From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org, axboe@kernel.dk,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/2] block: introduce zone capacity helper
Date: Tue, 18 Mar 2025 16:57:45 +0900 [thread overview]
Message-ID: <b527143b-6528-4817-9f48-9ee7ab874989@kernel.org> (raw)
In-Reply-To: <Z9kKfpY0E-phdJ5G@infradead.org>
On 3/18/25 2:54 PM, Christoph Hellwig wrote:
> On Tue, Mar 18, 2025 at 02:14:29PM +0900, Damien Le Moal wrote:
>> @pos is not the start of the zone, so this should be:
>>
>> * disk_zone_capacity - returns the capacity of the zone containing @sect
>>
>> And rename pos to sect.
>
> While we're nitpicking: sect is a bit weird, the block layer usually
> spells it out as sectors (sect sounds too close to the german word for
> sparkling wine anyway :))
Given that this is not a number of sectors, "sector" would be the right name
then :)
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-03-18 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 0:59 [PATCH v2 0/2] btrfs: zoned: skip reporting zone for new block group Naohiro Aota
2025-03-18 0:59 ` [PATCH v2 1/2] block: introduce zone capacity helper Naohiro Aota
2025-03-18 5:14 ` Damien Le Moal
2025-03-18 5:54 ` Christoph Hellwig
2025-03-18 7:57 ` Damien Le Moal [this message]
2025-03-18 8:04 ` Christoph Hellwig
2025-03-18 7:27 ` Johannes Thumshirn
2025-03-18 0:59 ` [PATCH v2 2/2] btrfs: zoned: skip reporting zone for new block group Naohiro Aota
2025-03-18 7:25 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b527143b-6528-4817-9f48-9ee7ab874989@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox