From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F2D12BEB7; Mon, 25 Mar 2024 07:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352485; cv=none; b=a0VNcFbWTQKhMwcJGNrocA935XyTAtWIaa3lyi2TA0/WCE5LUJDa+6qtt77tToIIh7S4J9QYtvNKjm/XJJ4taZb1Dr14a+7p7bdEf+z5F3bg4AXlm/ugAdEC6dcyk86rVCd/G9k8QzNBCawXtAJtT3jwL3hpkNApTDxYlT+T3PM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352485; c=relaxed/simple; bh=PaOjeQTXUXH777uBTd4u+MGPOvH/o5CMLR9zmwwiBA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AG2xB600jQlml+j3TEgcI8beBNZxdnaLYXuXP7U92ofElIHMrXZxCMmNVTYVzF+bJU1nTT8ozR6JkkccSmQ7DDItPJlJKNX5xI5cqW0vH6NaJS3k4IY+/7yFwB1rRTTyiy27OxUQJf5o26E11OIXXxpeaD5vN82nCpWNyzHpjA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jUQCtc4+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jUQCtc4+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D2DC433C7; Mon, 25 Mar 2024 07:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711352485; bh=PaOjeQTXUXH777uBTd4u+MGPOvH/o5CMLR9zmwwiBA4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jUQCtc4+99JJBf4KiYXqgHSnqGbKtWO2F3eDQObnbRVLVH3L6SA7JVXD8VuG4dPW+ JG0oxQEoo+lFF0BIOqX9/txggXEueMRPhvBjTdhVmyqeK3FA3A0WMW2FgIdvb38+MW HGi9UXjAw/EvJHGsg9ctp+ksfDNwKK5wDkGTQoBR7qjP6+QCMPRdoII7HIuDVNv46B dLqz1Jv3D5d9yaAuCmopm+nWiRNFcSB//NYEfuRzyHg0IXw/Y+ZeAz6mzFeGK4Vt2y K7A8t7TTZquOBBWgJ2PYjBXWh+5kgOjMXy453NOxQitsLuWhRGLR8Kx//Xdtb6t7O/ nazjXSK4iYNwQ== Message-ID: Date: Mon, 25 Mar 2024 16:41:18 +0900 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/23] mpt3sas: switch to using ->device_configure Content-Language: en-US To: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" Cc: Niklas Cassel , Takashi Sakamoto , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "Juergen E. Fischer" , Xiang Chen , HighPoint Linux Team , Tyrel Datwyler , Brian King , Lee Duncan , Chris Leech , Mike Christie , John Garry , Jason Yan , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Jack Wang , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Greg Kroah-Hartman , Alim Akhtar , Avri Altman , Bart Van Assche , Krzysztof Kozlowski , Alan Stern , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux1394-devel@lists.sourceforge.net, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com, megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20240324235448.2039074-1-hch@lst.de> <20240324235448.2039074-13-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20240324235448.2039074-13-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research