From: Wang Jianchao <jianchao.wan9@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Adam Manzanares <adam.manzanares@wdc.com>
Subject: Re: [PATCH 0/9] Improve I/O priority support
Date: Thu, 27 May 2021 14:25:48 +0800 [thread overview]
Message-ID: <b58840a8-0122-26cd-e756-92562064075a@gmail.com> (raw)
In-Reply-To: <20210527010134.32448-1-bvanassche@acm.org>
On 2021/5/27 9:01 AM, Bart Van Assche wrote:
> Hi Jens,
>
> A feature that is missing from the Linux kernel for storage devices that
> support I/O priorities is to set the I/O priority in requests involving page
> cache writeback. Since the identity of the process that triggers page cache
> writeback is not known in the writeback code, the priority set by ioprio_set()
> is ignored. However, an I/O cgroup is associated with writeback requests
> by certain filesystems. Hence this patch series that implements the following
> changes for the mq-deadline scheduler:
Hi Bart
How about implement this feature based on the rq-qos framework ?
Maybe it is better to make mq-deadline a pure io-scheduler.
Best regards
Jianchao
> * Make the I/O priority configurable per I/O cgroup.
> * Change the I/O priority of requests to the lower of (request I/O priority,
> cgroup I/O priority).
> * Introduce one queue per I/O priority in the mq-deadline scheduler.
>
> Please consider this patch series for kernel v5.14.
>
> Thanks,
>
> Bart.
>
> Bart Van Assche (9):
> block/mq-deadline: Add several comments
> block/mq-deadline: Add two lockdep_assert_held() statements
> block/mq-deadline: Remove two local variables
> block/mq-deadline: Rename dd_init_queue() and dd_exit_queue()
> block/mq-deadline: Improve compile-time argument checking
> block/mq-deadline: Reduce the read expiry time for non-rotational
> media
> block/mq-deadline: Reserve 25% of tags for synchronous requests
> block/mq-deadline: Add I/O priority support
> block/mq-deadline: Add cgroup support
>
> block/Kconfig.iosched | 6 +
> block/Makefile | 1 +
> block/mq-deadline-cgroup.c | 206 +++++++++++++++
> block/mq-deadline-cgroup.h | 73 ++++++
> block/mq-deadline.c | 524 +++++++++++++++++++++++++++++--------
> 5 files changed, 695 insertions(+), 115 deletions(-)
> create mode 100644 block/mq-deadline-cgroup.c
> create mode 100644 block/mq-deadline-cgroup.h
>
next prev parent reply other threads:[~2021-05-27 6:26 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 1:01 [PATCH 0/9] Improve I/O priority support Bart Van Assche
2021-05-27 1:01 ` [PATCH 1/9] block/mq-deadline: Add several comments Bart Van Assche
2021-05-27 3:03 ` Damien Le Moal
2021-05-27 6:45 ` Hannes Reinecke
2021-05-27 19:30 ` Bart Van Assche
2021-05-27 8:43 ` Johannes Thumshirn
2021-05-27 15:13 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 2/9] block/mq-deadline: Add two lockdep_assert_held() statements Bart Van Assche
2021-05-27 2:25 ` Chaitanya Kulkarni
2021-05-27 3:09 ` Damien Le Moal
2021-05-27 6:46 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:14 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 3/9] block/mq-deadline: Remove two local variables Bart Van Assche
2021-05-27 2:26 ` Chaitanya Kulkarni
2021-05-27 3:11 ` Damien Le Moal
2021-05-27 6:46 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:15 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 4/9] block/mq-deadline: Rename dd_init_queue() and dd_exit_queue() Bart Van Assche
2021-05-27 2:27 ` Chaitanya Kulkarni
2021-05-27 3:13 ` Damien Le Moal
2021-05-27 19:33 ` Bart Van Assche
2021-05-27 6:47 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:16 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 5/9] block/mq-deadline: Improve compile-time argument checking Bart Van Assche
2021-05-27 2:28 ` Chaitanya Kulkarni
2021-05-27 3:24 ` Damien Le Moal
2021-05-27 19:38 ` Bart Van Assche
2021-05-28 1:42 ` Damien Le Moal
2021-05-27 6:48 ` Hannes Reinecke
2021-05-27 8:49 ` Johannes Thumshirn
2021-05-27 15:19 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media Bart Van Assche
2021-05-27 2:30 ` Chaitanya Kulkarni
2021-05-27 3:27 ` Damien Le Moal
2021-05-27 19:43 ` Bart Van Assche
2021-05-27 6:52 ` Hannes Reinecke
2021-05-27 15:20 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 7/9] block/mq-deadline: Reserve 25% of tags for synchronous requests Bart Van Assche
2021-05-27 3:33 ` Damien Le Moal
2021-05-27 20:00 ` Bart Van Assche
2021-05-27 6:54 ` Hannes Reinecke
2021-05-27 19:55 ` Bart Van Assche
2021-05-27 1:01 ` [PATCH 8/9] block/mq-deadline: Add I/O priority support Bart Van Assche
2021-05-27 3:48 ` Damien Le Moal
2021-05-27 20:12 ` Bart Van Assche
2021-05-27 7:07 ` Hannes Reinecke
2021-05-27 20:23 ` Bart Van Assche
2021-05-28 1:40 ` Damien Le Moal
2021-05-27 1:01 ` [PATCH 9/9] block/mq-deadline: Add cgroup support Bart Van Assche
2021-05-27 7:09 ` Hannes Reinecke
2021-05-27 6:25 ` Wang Jianchao [this message]
2021-05-27 8:05 ` [PATCH 0/9] Improve I/O priority support Wang Jianchao
2021-05-27 18:40 ` Bart Van Assche
2021-05-28 2:05 ` Wang Jianchao
2021-05-28 8:43 ` Paolo Valente
2021-05-28 16:28 ` Bart Van Assche
2021-05-27 8:56 ` Johannes Thumshirn
2021-05-27 17:23 ` Chaitanya Kulkarni
2021-05-27 19:00 ` Bart Van Assche
2021-05-27 17:58 ` Adam Manzanares
2021-05-27 18:53 ` Bart Van Assche
2021-05-27 22:45 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b58840a8-0122-26cd-e756-92562064075a@gmail.com \
--to=jianchao.wan9@gmail.com \
--cc=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox