From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CC4C54EAA for ; Fri, 27 Jan 2023 07:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232141AbjA0HAj (ORCPT ); Fri, 27 Jan 2023 02:00:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232211AbjA0HAg (ORCPT ); Fri, 27 Jan 2023 02:00:36 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1470C29406; Thu, 26 Jan 2023 23:00:32 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2B6C1FEB2; Fri, 27 Jan 2023 07:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674802830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/kg5AS6XYWWstGUf7pEtDuX/nvVku38MMV3LB6qGdE=; b=PqtEAMhUDo4Cv2ao3GZl9fsH1VoKurVnAmgnUK9Nx1pqAlMQhRlMy4AuadG4FirggtT5Qh XX88OGjVGeBrHjBK69n9HyTRyD4UBMysLIFv6SoAF/fNlwoWiGc6rXbSISjr5LD+DLif9u p0+4jACKtAsOp7D51wl84Zpej3H4lsQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674802830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/kg5AS6XYWWstGUf7pEtDuX/nvVku38MMV3LB6qGdE=; b=9Jrff9C5cwNap80CFNbaVK9nxoVT2m1hYtjlv94BjVoFDPuNUtwt7rlxWu0yqKwrUzRZwa aARTfRVOMETot9Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 88D211336F; Fri, 27 Jan 2023 07:00:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aL1FII5202OQUQAAMHmgww (envelope-from ); Fri, 27 Jan 2023 07:00:30 +0000 Message-ID: Date: Fri, 27 Jan 2023 08:00:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 02/15] block: don't call blk_throtl_stat_add for non-READ/WRITE commands Content-Language: en-US To: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org References: <20230117081257.3089859-1-hch@lst.de> <20230117081257.3089859-3-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230117081257.3089859-3-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 1/17/23 09:12, Christoph Hellwig wrote: > blk_throtl_stat_add is called from blk_stat_add explicitly, unlike the > other stats that go through q->stats->callbacks. To prepare for cgroup > data moving to the gendisk, ensure blk_throtl_stat_add is only called > for the plain READ and WRITE commands that it actually handles internally, > as blk_stat_add can also be called for passthrough commands on queues that > do not have a genisk associated with them. > > Signed-off-by: Christoph Hellwig > --- > block/blk-stat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman