From: Jens Axboe <axboe@kernel.dk>
To: Yoav Cohen <yoav@nvidia.com>, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, csander@purestorage.com,
alex@zazolabs.com
Cc: jholzman@nvidia.com, omril@nvidia.com, Yoav Cohen <yoav@example.com>
Subject: Re: [PATCH v6 0/3] ublk: introduce UBLK_CMD_TRY_STOP_DEV
Date: Mon, 12 Jan 2026 09:22:06 -0700 [thread overview]
Message-ID: <b784bf25-78aa-42cf-bf3b-0687d9138139@kernel.dk> (raw)
In-Reply-To: <20260112133648.51722-1-yoav@nvidia.com>
Please rebase this on the current for-7.0/block tree. It doesn't
apply at all, and hunks like:
@@ -311,6 +312,12 @@
*/
#define UBLK_F_BUF_REG_OFF_DAEMON (1ULL << 14)
+/*
+ * The device supports the UBLK_CMD_TRY_STOP_DEV command, which
+ * allows stopping the device only if there are no openers.
+ */
+#define UBLK_F_SAFE_STOP_DEV (1ULL << 17)
+
/* device state */
#define UBLK_S_DEV_DEAD 0
#define UBLK_S_DEV_LIVE 1
is a clear sign that your way off base at this point. Why else would
STOP_DEV be 1 << 17, with the previous one at 1 << 14?
--
Jens Axboe
next prev parent reply other threads:[~2026-01-12 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 13:36 [PATCH v6 0/3] ublk: introduce UBLK_CMD_TRY_STOP_DEV Yoav Cohen
2026-01-12 13:36 ` [PATCH v6 1/3] ublk: make ublk_ctrl_stop_dev return void Yoav Cohen
2026-01-12 13:36 ` [PATCH v6 2/3] ublk: add UBLK_CMD_TRY_STOP_DEV command Yoav Cohen
2026-01-12 13:36 ` [PATCH v6 3/3] selftests: ublk: add stop command with --safe option Yoav Cohen
2026-01-12 16:22 ` Jens Axboe [this message]
2026-01-12 16:28 ` [PATCH v6 0/3] ublk: introduce UBLK_CMD_TRY_STOP_DEV Caleb Sander Mateos
2026-01-12 16:33 ` Jens Axboe
2026-01-12 17:07 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b784bf25-78aa-42cf-bf3b-0687d9138139@kernel.dk \
--to=axboe@kernel.dk \
--cc=alex@zazolabs.com \
--cc=csander@purestorage.com \
--cc=jholzman@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=omril@nvidia.com \
--cc=yoav@example.com \
--cc=yoav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox