linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 章辉 <zhanghui31@xiaomi.com>
To: Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@kernel.dk>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [External Mail]Re: [PATCH v3] block: move non sync requests complete flow to softirq
Date: Thu, 5 Sep 2024 02:52:36 +0000	[thread overview]
Message-ID: <b89bd2e5-ff8d-4e29-b082-9129284a51cb@xiaomi.com> (raw)
In-Reply-To: <ZtfiK1xg2RVzkXW9@infradead.org>

On 2024/9/4 12:29, Christoph Hellwig wrote:
> On Tue, Sep 03, 2024 at 11:49:28AM -0600, Jens Axboe wrote:
>> The elephant in the room here is why an 80M completion takes 100 msec?
>> That seems... insane.
>>
>> That aside, doing writes that big isn't great for latencies in general,
>> even if they are orders of magnitude smaller (as they should be). Maybe
>> this is solvable by just limiting the write size here.
>>
>> But it really seems out of line for a write that size to take 100 msec
>> to process.
> pagecache state processing is quite inefficient, we had to limit
> the number of them for XFS to avoid latency problems a while ago.
> Note that moving to folios means you can process a lot more data
> with the same number of completion iterations as well.  I'd suggest
> the submitter looks into that for whatever file system they are using.
>
hi Christoph,

The F2FS file system is used on the smartphone, and end_io uses page
traversal instead of folio traversal.
I will confirm the plan to migrate to folio. Thank you!

Thanks
Zhang


  reply	other threads:[~2024-09-05  2:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 11:54 [PATCH v3] block: move non sync requests complete flow to softirq ZhangHui
2024-09-03 17:28 ` Bart Van Assche
2024-09-03 17:47   ` Jens Axboe
2024-09-04  3:35   ` [External Mail]Re: " 章辉
2024-09-04 17:22     ` Bart Van Assche
2024-09-05  3:05       ` 章辉
2024-09-03 17:49 ` Jens Axboe
2024-09-04  3:25   ` [External Mail]Re: " 章辉
2024-09-04  4:29   ` Christoph Hellwig
2024-09-05  2:52     ` 章辉 [this message]
2024-09-04  8:01 ` Ming Lei
2024-09-05  2:46   ` [External Mail]Re: " 章辉
2024-09-05  3:49     ` Ming Lei
2024-09-05  7:33       ` 章辉

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b89bd2e5-ff8d-4e29-b082-9129284a51cb@xiaomi.com \
    --to=zhanghui31@xiaomi.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).