From: Jens Axboe <axboe@kernel.dk>
To: Geoff Levand <geoff@infradead.org>, linux-block@vger.kernel.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 03/17] ps3disk: convert to blk-mq
Date: Mon, 15 Oct 2018 10:27:12 -0600 [thread overview]
Message-ID: <b95e3ebf-f08d-2cbf-3f82-89424d7bf60d@kernel.dk> (raw)
In-Reply-To: <7f27a68f-9cbe-c4c2-5c35-70763a5b1484@infradead.org>
On 10/15/18 10:22 AM, Geoff Levand wrote:
> Hi Jens,
>
> On 10/12/2018 05:58 PM, Jens Axboe wrote:
>> On 10/12/18 4:47 PM, Geoff Levand wrote:
>>> On 10/11/2018 09:58 AM, Jens Axboe wrote:
>>>> Convert from the old request_fn style driver to blk-mq.
>>>
>>> I tested this on PS3 applied to v4.19-rc7, and on boot it either
>>> gets a deadlock message or becomes unstable with various other
>>> block related error messages.
>>>
>>> For what its worth, I put an image of the deadlock message here:
>>>
>>> https://storage.googleapis.com/public-tmp-files/blk-deadlock.jpg
>>
>> Thanks for testing! Can you try this incremental? It's mostly just
>> a cleanup on top, but the last hunk should be the thing that
>> hopefully makes this tick again. If you prefer just using a new
>> patch, this one is updated:
>>
>> http://git.kernel.dk/cgit/linux-block/commit/?h=mq-conversions&id=5c86f76f45e7c8d5a47a1f20b3e7b93fc945168a
>
> I tested your V2 applied to v4.19-rc8 and it works a little
> better, in that the system will now boot up, but the ps3disk
> still gets hung up.
>
> I added a '#define DEBUG' to ps3disk.c and saved the dmesg
> output with and without the patch here:
>
> https://storage.googleapis.com/public-tmp-files/dmesg-ok.txt
> https://storage.googleapis.com/public-tmp-files/dmesg-ng.txt
>
> Looking at dmesg-ng.txt, it seems things are going OK, but then
> go wrong with a 'tag mismatch':
>
> [ 6.068298] ps3disk sb_03: ps3disk_do_request:193
> [ 6.068318] ps3disk sb_03: ps3disk_submit_request_sg:140: read req has 2 bvecs for 16 sectors
> [ 6.068339] ps3disk sb_03: ps3disk_submit_request_sg:146: read 16 sectors starting at 256
> [ 6.074231] ps3disk sb_03: ps3disk_interrupt:239: tag mismatch, got 0, expected 1
> [ 6.084125] ps3disk sb_03: ps3disk_interrupt:271: read completed
> [ 6.084147] ps3disk sb_03: ps3disk_scatter_gather:107: bio 0: 16 sectors from 256
> [ 6.084174] ps3disk sb_03: ps3disk_scatter_gather:107: bio 1: 16 sectors from 256
> [ 6.084405] ps3disk sb_03: ps3disk_interrupt:252 non-block layer request completed
> ...
> [ 242.657694] INFO: task blkid:563 blocked for more than 120 seconds.
>
> Geert is the original author of the PS3 disk support. Geert,
> can you see anything wrong in the patch?
Can you try and change the queue depth to 1 instead of 2? It's set in
the tag_set, as ->queue_depth.
--
Jens Axboe
next prev parent reply other threads:[~2018-10-15 16:27 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 16:58 [PATCHSET 0/17] Convert drivers to blk-mq Jens Axboe
2018-10-11 16:58 ` [PATCH 01/17] sunvdc: convert " Jens Axboe
2018-10-15 10:38 ` Ming Lei
2018-10-15 14:19 ` Jens Axboe
2018-10-15 14:50 ` Jens Axboe
2018-10-11 16:58 ` [PATCH 02/17] sx8: " Jens Axboe
2018-10-11 16:58 ` [PATCH 03/17] ps3disk: " Jens Axboe
2018-10-12 22:47 ` Geoff Levand
2018-10-13 0:58 ` Jens Axboe
2018-10-15 16:22 ` Geoff Levand
2018-10-15 16:27 ` Jens Axboe [this message]
2018-10-15 16:47 ` Jens Axboe
2018-10-15 18:23 ` Geoff Levand
2018-10-15 18:38 ` Jens Axboe
2018-10-15 19:09 ` Jens Axboe
2018-10-15 19:24 ` Geoff Levand
2018-10-15 19:30 ` Jens Axboe
2018-10-11 16:58 ` [PATCH 04/17] paride: convert pcd " Jens Axboe
2018-10-11 16:58 ` [PATCH 05/17] paride: convert pd " Jens Axboe
2018-10-11 16:58 ` [PATCH 06/17] paride: convert pf " Jens Axboe
2018-10-11 16:58 ` [PATCH 07/17] uml: convert ubd " Jens Axboe
2018-10-15 10:27 ` Ming Lei
2018-10-15 14:16 ` Jens Axboe
2018-10-11 16:59 ` [PATCH 08/17] ms_block: convert " Jens Axboe
2018-10-14 6:30 ` Maxim Levitsky
2018-10-11 16:59 ` [PATCH 09/17] mspro_block: " Jens Axboe
2018-10-11 16:59 ` [PATCH 10/17] gdrom: " Jens Axboe
2018-10-11 16:59 ` [PATCH 11/17] z2ram: " Jens Axboe
2018-10-11 16:59 ` [PATCH 12/17] blk-mq-sched: export way for drivers to insert request Jens Axboe
2018-10-14 18:49 ` Christoph Hellwig
2018-10-14 18:56 ` Jens Axboe
2018-10-11 16:59 ` [PATCH 13/17] ide: convert to blk-mq Jens Axboe
2018-10-11 16:59 ` [PATCH 14/17] aoe: convert aoeblk " Jens Axboe
2018-10-12 11:28 ` Ed Cashin
2018-10-12 14:20 ` Jens Axboe
2018-10-12 16:17 ` Ed Cashin
2018-10-12 16:23 ` Jens Axboe
2018-10-12 16:26 ` Ed Cashin
2018-10-14 0:48 ` Ed Cashin
2018-10-14 18:44 ` Jens Axboe
2018-10-11 16:59 ` [PATCH 15/17] xsysace: convert " Jens Axboe
2018-10-12 5:46 ` Michal Simek
2018-10-11 16:59 ` [PATCH 16/17] mtd_blkdevs: " Jens Axboe
2018-10-11 21:03 ` Richard Weinberger
2018-10-11 21:14 ` Jens Axboe
2018-10-11 21:18 ` Richard Weinberger
2018-10-11 21:21 ` Jens Axboe
2018-10-11 21:31 ` Richard Weinberger
2018-10-11 16:59 ` [PATCH 17/17] null_blk: remove legacy IO path Jens Axboe
2018-10-12 6:56 ` Dongli Zhang
2018-10-12 8:51 ` Johannes Thumshirn
2018-10-12 14:18 ` Jens Axboe
2018-10-12 17:24 ` Sébastien Boisvert
2018-10-12 17:30 ` Jens Axboe
2018-10-12 17:37 ` Sébastien Boisvert
2018-10-12 17:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95e3ebf-f08d-2cbf-3f82-89424d7bf60d@kernel.dk \
--to=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox