From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EB43C583B; Wed, 27 May 2026 18:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905176; cv=none; b=Uu+5hwwgD1kkSV1UYBLT80TS+pVeaOXXjI5sCfWzCX79GAXu1fupy88oW0H0aiCbTYnZH23p4PrzLDl3iNE5RNhbfaUasxv6526HgFrFPJzv1GUr9YO54CjFqL/ULNYKvFEiuMTGUz+FixXxn6OKaZPFKAGLNtln7ul0kchgrjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779905176; c=relaxed/simple; bh=4ynxLGq8Tq6N3l/4qPYz5DvdlYzFN3mdDCXp/vSoefc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PrEUdY/tqXIIF1Q7LblbNCUYQDDYSQYtcmrclMhOz6FmeFRUyv4ULnLvkuyAYfyW2LskS1pH+kDj5/egaAvaUUnKxaERwYkJ0V2hYpPNtrPWWYTT8lDGYjM5t2URAvP2+1rd3maQXUUL6ITGV1IK81NSPmadcVleaWR9p6/2mu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XkeYlKla; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XkeYlKla" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8E0F1F000E9; Wed, 27 May 2026 18:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779905175; bh=jqVJcUgPxUF+veB1WjKysV5XgWlSW8zAy9W8I7TfmWY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=XkeYlKlaOV4r9NQo+KZZMzid8GXX3wMD5sHbirRqLdS8jU+SLanW28ZcRbd+xhdn7 wTibJDx9/45Sx8YCANjmzR0zh8XZIbbjAOpP42FozftfnAshIiQie89gKUw+SrsiFH jA5tUhc2uOcuqZC5Degja4N0s+rTbdoljYBXjirbpS9nFiNofiFU8vKXWpMLOaVnKQ YC2iQJ1z12tVr7OtuVObxrq9ANhhRF2mGBkmt5nuJDnN5UKo9INA0tdxWpcOv6wpUI N2Bo+ncYzaZNjPg5Fv1t9r+CFV/mDiv/VTrRKKTxRumYXyiiqPO3/K+STlX2crDRbY UkUz62cUpcAug== Message-ID: Date: Thu, 28 May 2026 03:06:12 +0900 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: blk-zoned: fix zwplug refcount leak on write error path To: Shin'ichiro Kawasaki Cc: Haris Iqbal , Wentao Liang , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260526141824.2293025-1-vulab@iscas.ac.cn> <90a1581d-9a3c-46db-bc7b-5fd1a9d9c0e1@kernel.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/05/27 20:47, Shin'ichiro Kawasaki wrote: > On May 27, 2026 / 08:15, Damien Le Moal wrote: > [...] >> Wentao, >> >> You clearly did not test this at all because if you had, you would have seen >> all the warning splats that your patch triggers. > > FYI, the blktests CI run for the patch caught failures at block/017, zbd/004, > zbd/009 and zbd/012. Thanks Shin'ichiro. I did a simple manual test issuing an unaligned write with dd on a zloop device. That was enough to trigger warnings similar to what the CI reported. -- Damien Le Moal Western Digital Research