From: Mikulas Patocka <mpatocka@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATC] block: update queue limits atomically
Date: Tue, 18 Mar 2025 17:13:04 +0100 (CET) [thread overview]
Message-ID: <bbc48d3c-e221-8429-0753-d9d48462b19c@redhat.com> (raw)
In-Reply-To: <14dd4360-c846-43e3-86bc-b1e7448e5896@acm.org>
On Tue, 18 Mar 2025, Bart Van Assche wrote:
> On 3/18/25 7:26 AM, Mikulas Patocka wrote:
> > The block limits may be read while they are being modified. The statement
> > "q->limits = *lim" is not really atomic. The compiler may turn it into
> > memcpy (clang does).
>
> Which code reads block limits while these are being updated?
See my reply to Ming -
https://lore.kernel.org/dm-devel/14dd4360-c846-43e3-86bc-b1e7448e5896@acm.org/T/#m7e4e49fed1cbcb56954b880e54a5155c4089c0e0
> This should be mentioned in the patch description.
>
> Bart.
Yes, I can add it there.
Mikulas
next prev parent reply other threads:[~2025-03-18 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 14:26 [PATC] block: update queue limits atomically Mikulas Patocka
2025-03-18 14:56 ` Ming Lei
2025-03-18 15:31 ` Mikulas Patocka
2025-03-19 1:22 ` Ming Lei
2025-03-19 1:58 ` Jens Axboe
2025-03-19 21:18 ` Mikulas Patocka
2025-03-20 2:22 ` Ming Lei
2025-03-20 12:58 ` Jens Axboe
2025-03-20 5:26 ` Christoph Hellwig
2025-03-18 15:58 ` Bart Van Assche
2025-03-18 16:13 ` Mikulas Patocka [this message]
2025-03-20 5:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc48d3c-e221-8429-0753-d9d48462b19c@redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox