Re: sysfs integrity fields use

[Milan Broz <gmazyland@gmail.com>]

Hi,

On 2/25/25 4:38 PM, Christoph Hellwig wrote:
...
> 
>> Then we have new (undocumented) value for NVMe in
>> - /sys/block/<nvme>/integrity/metadata_bytes
>>    This contains the correct 64.
> 
> Yes, this contains the full size of the metadata.  And besides
> documenting it we should probably also lift it to the block layer.

yes, this is exactly what I need, just it should be present
for all block devices.
  
>> Anyway, when I try to use it (for authentication tags in dm-crypt), it works.
>>
>> Should tag_size and device_is_integrity_capable be set even for the "nop" format?
>> Is it a bug or a feature? :-)
> 
> It is expected.  The only issue is that the block support for metadata
> is called integrity all over because it was initially added for PI only
> and then extended for non-PI metadata, which makes things a little
> confusing.

ok, that make sense. Maybe the note should be added to sysfs doc too.

Thanks,
Milan