Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] cfq: Disable writeback throttling by default
Date: Wed, 5 Apr 2017 08:16:05 -0600	[thread overview]
Message-ID: <bd122646-b001-dd53-9aa6-6a732d345624@kernel.dk> (raw)
In-Reply-To: <20170404123130.23151-1-jack@suse.cz>

On 04/04/2017 06:31 AM, Jan Kara wrote:
> Writeback throttling does not play well with CFQ since that also tries
> to throttle async writes. As a result async writeback can get starved in
> presence of readers. As an example take a benchmark simulating
> postgreSQL database running over a standard rotating SATA drive. There
> are 16 processes doing random reads from a huge file (2*machine memory),
> 1 process doing random writes to the huge file and calling fsync once
> per 50000 writes and 1 process doing sequential 8k writes to a
> relatively small file wrapping around at the end of the file and calling
> fsync every 5 writes. Under this load read latency easily exceeds the
> target latency of 75 ms (just because there are so many reads happening
> against a relatively slow disk) and thus writeback is throttled to a
> point where only 1 write request is allowed at a time.

Thanks Jan, it's probably really hard to ever combine anything with
CFQ, since it does its own thing. I have applied the patch.

-- 
Jens Axboe

      reply	other threads:[~2017-04-05 14:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 12:31 [PATCH] cfq: Disable writeback throttling by default Jan Kara
2017-04-05 14:16 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd122646-b001-dd53-9aa6-6a732d345624@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox