From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 4/4] block: move update request helpers into blk-mq.c
Date: Thu, 14 Oct 2021 09:14:34 -0600 [thread overview]
Message-ID: <bd531677-0d1c-c6d7-fb7f-3b8dd40a4e64@kernel.dk> (raw)
In-Reply-To: <YWe5h25TVmF3V05w@infradead.org>
On 10/13/21 11:00 PM, Christoph Hellwig wrote:
> On Wed, Oct 13, 2021 at 11:57:51AM -0600, Jens Axboe wrote:
>> It's not like they are conditionally enabled, if you get one you get
>> the other. But I can shuffle it around if it means a lot to you...
>
> As I've been trying to reshuffle the files and data structures to
> keep the bio and requests bits clearly separated I'd appreciate if we
> can keep the status codes in core.c and just do the long overdue move
> the request completion helers.
Fair enough, I'll leave the error stuff in blk-core, doesn't really matter
anyway as it should be out-of-line.
> And as said before: I think we should fix the trace point to not
> unconditionally call the status to errno conversion first as not doing
> it at all for the fast path will be even faster than inlining it :)
I'll do that as separate patch on top.
--
Jens Axboe
prev parent reply other threads:[~2021-10-14 15:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 16:49 [PATCHSET 0/4] Various block optimizations Jens Axboe
2021-10-13 16:49 ` [PATCH 1/4] block: provide helpers for rq_list manipulation Jens Axboe
2021-10-13 17:11 ` Christoph Hellwig
2021-10-13 17:47 ` Jens Axboe
2021-10-13 16:49 ` [PATCH 2/4] block: inline fast path of driver tag allocation Jens Axboe
2021-10-13 17:22 ` Christoph Hellwig
2021-10-13 17:46 ` Jens Axboe
2021-10-13 17:57 ` Christoph Hellwig
2021-10-13 18:07 ` Jens Axboe
2021-10-13 16:49 ` [PATCH 3/4] block: don't bother iter advancing a fully done bio Jens Axboe
2021-10-13 17:26 ` Christoph Hellwig
2021-10-13 17:46 ` Jens Axboe
2021-10-13 16:49 ` [PATCH 4/4] block: move update request helpers into blk-mq.c Jens Axboe
2021-10-13 17:32 ` Christoph Hellwig
2021-10-13 17:46 ` Jens Axboe
2021-10-13 17:54 ` Christoph Hellwig
2021-10-13 17:57 ` Jens Axboe
2021-10-14 5:00 ` Christoph Hellwig
2021-10-14 15:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd531677-0d1c-c6d7-fb7f-3b8dd40a4e64@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox