* [PATCH v2] lib/crc64.c: add license information
@ 2018-05-22 8:54 Coly Li
2018-05-22 9:01 ` Coly Li
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2018-05-22 8:54 UTC (permalink / raw)
To: linux-bcache; +Cc: linux-block, Coly Li
This patch adds MODULE_LICENSE("GPL") to remove a kernel build warning
information. Also as Andy Shevchenko suggested, adds a SPDX header into
lib/crc64.c file.
Signed-off-by: Coly Li <colyli@suse.de>
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/crc64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/crc64.c b/lib/crc64.c
index ed0ffac7b26a..30d1bb58dd5c 100644
--- a/lib/crc64.c
+++ b/lib/crc64.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group (Any
* use permitted, subject to terms of PostgreSQL license; see.)
@@ -135,3 +136,4 @@ uint64_t crc64(const void *data, size_t len)
EXPORT_SYMBOL_GPL(crc64);
MODULE_DESCRIPTION("CRC64 calculations");
+MODULE_LICENSE("GPL");
--
2.16.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lib/crc64.c: add license information
2018-05-22 8:54 [PATCH v2] lib/crc64.c: add license information Coly Li
@ 2018-05-22 9:01 ` Coly Li
2018-05-22 9:53 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2018-05-22 9:01 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-bcache, linux-block
On 2018/5/22 4:54 PM, Coly Li wrote:
> This patch adds MODULE_LICENSE("GPL") to remove a kernel build warning
> information. Also as Andy Shevchenko suggested, adds a SPDX header into
> lib/crc64.c file.
>
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Andy,
Could you please to offer a Reviewed-by or Acked-by ? We have an
agreement that every patch should have a peer reviewer, at this moment
we are lack of code reviewer but I still want to keep this rule as much
as I can.
Thanks in advance.
Coly Li
> ---
> lib/crc64.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/crc64.c b/lib/crc64.c
> index ed0ffac7b26a..30d1bb58dd5c 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group (Any
> * use permitted, subject to terms of PostgreSQL license; see.)
> @@ -135,3 +136,4 @@ uint64_t crc64(const void *data, size_t len)
> EXPORT_SYMBOL_GPL(crc64);
>
> MODULE_DESCRIPTION("CRC64 calculations");
> +MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lib/crc64.c: add license information
2018-05-22 9:01 ` Coly Li
@ 2018-05-22 9:53 ` Andy Shevchenko
2018-05-22 9:55 ` Coly Li
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-05-22 9:53 UTC (permalink / raw)
To: Coly Li; +Cc: linux-bcache, linux-block
On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote:
> On 2018/5/22 4:54 PM, Coly Li wrote:
> > This patch adds MODULE_LICENSE("GPL") to remove a kernel build
> > warning
> > information. Also as Andy Shevchenko suggested, adds a SPDX header
> > into
> > lib/crc64.c file.
> >
> Could you please to offer a Reviewed-by or Acked-by ? We have an
> agreement that every patch should have a peer reviewer, at this moment
> we are lack of code reviewer but I still want to keep this rule as
> much
> as I can.
I would love to, but I'm not a lawyer. I can't do it in _this_ case,
sorry.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lib/crc64.c: add license information
2018-05-22 9:53 ` Andy Shevchenko
@ 2018-05-22 9:55 ` Coly Li
2018-05-22 10:01 ` Kent Overstreet
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2018-05-22 9:55 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-bcache, linux-block
On 2018/5/22 5:53 PM, Andy Shevchenko wrote:
> On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote:
>> On 2018/5/22 4:54 PM, Coly Li wrote:
>>> This patch adds MODULE_LICENSE("GPL") to remove a kernel build
>>> warning
>>> information. Also as Andy Shevchenko suggested, adds a SPDX header
>>> into
>>> lib/crc64.c file.
>>>
>
>> Could you please to offer a Reviewed-by or Acked-by ? We have an
>> agreement that every patch should have a peer reviewer, at this moment
>> we are lack of code reviewer but I still want to keep this rule as
>> much
>> as I can.
>
> I would love to, but I'm not a lawyer. I can't do it in _this_ case,
> sorry.
>
OK... Then I have to ask someone else to review this patch.
Thanks.
Coly Li
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lib/crc64.c: add license information
2018-05-22 9:55 ` Coly Li
@ 2018-05-22 10:01 ` Kent Overstreet
2018-05-22 10:27 ` Coly Li
0 siblings, 1 reply; 6+ messages in thread
From: Kent Overstreet @ 2018-05-22 10:01 UTC (permalink / raw)
To: Coly Li; +Cc: Andy Shevchenko, linux-bcache, linux-block
Postgresql is under its own license, which is basically the BSD
license under a different name.
I don't know if there's precedent for calling that BSD or if you
should just say the postgresql license.
On Tue, May 22, 2018 at 5:55 AM, Coly Li <colyli@suse.de> wrote:
> On 2018/5/22 5:53 PM, Andy Shevchenko wrote:
>> On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote:
>>> On 2018/5/22 4:54 PM, Coly Li wrote:
>>>> This patch adds MODULE_LICENSE("GPL") to remove a kernel build
>>>> warning
>>>> information. Also as Andy Shevchenko suggested, adds a SPDX header
>>>> into
>>>> lib/crc64.c file.
>>>>
>>
>>> Could you please to offer a Reviewed-by or Acked-by ? We have an
>>> agreement that every patch should have a peer reviewer, at this moment
>>> we are lack of code reviewer but I still want to keep this rule as
>>> much
>>> as I can.
>>
>> I would love to, but I'm not a lawyer. I can't do it in _this_ case,
>> sorry.
>>
>
> OK... Then I have to ask someone else to review this patch.
>
> Thanks.
>
> Coly Li
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lib/crc64.c: add license information
2018-05-22 10:01 ` Kent Overstreet
@ 2018-05-22 10:27 ` Coly Li
0 siblings, 0 replies; 6+ messages in thread
From: Coly Li @ 2018-05-22 10:27 UTC (permalink / raw)
To: Kent Overstreet; +Cc: Andy Shevchenko, linux-bcache, linux-block
On 2018/5/22 6:01 PM, Kent Overstreet wrote:
> Postgresql is under its own license, which is basically the BSD
> license under a different name.
>
> I don't know if there's precedent for calling that BSD or if you
> should just say the postgresql license.
>
Oh, I just realize the original code is PostgreSQL license. So we cannot
export the symbols by EXPORT_SYMBOL_GPL(). Add Linux kernel requires
lib/crc64.c has a license statement by MODULE_LICENSE(), and I don't see
anywhere else uses MODULE_LICENSE("PostgreSQL").
So I need to ask help from lawyers, and for this moment I will hold
related patches for 4.18.
Thanks.
> On Tue, May 22, 2018 at 5:55 AM, Coly Li <colyli@suse.de> wrote:
>> On 2018/5/22 5:53 PM, Andy Shevchenko wrote:
>>> On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote:
>>>> On 2018/5/22 4:54 PM, Coly Li wrote:
>>>>> This patch adds MODULE_LICENSE("GPL") to remove a kernel build
>>>>> warning
>>>>> information. Also as Andy Shevchenko suggested, adds a SPDX header
>>>>> into
>>>>> lib/crc64.c file.
>>>>>
>>>
>>>> Could you please to offer a Reviewed-by or Acked-by ? We have an
>>>> agreement that every patch should have a peer reviewer, at this moment
>>>> we are lack of code reviewer but I still want to keep this rule as
>>>> much
>>>> as I can.
>>>
>>> I would love to, but I'm not a lawyer. I can't do it in _this_ case,
>>> sorry.
>>>
>>
>> OK... Then I have to ask someone else to review this patch.
>>
>> Thanks.
>>
>> Coly Li
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-22 10:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-22 8:54 [PATCH v2] lib/crc64.c: add license information Coly Li
2018-05-22 9:01 ` Coly Li
2018-05-22 9:53 ` Andy Shevchenko
2018-05-22 9:55 ` Coly Li
2018-05-22 10:01 ` Kent Overstreet
2018-05-22 10:27 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).