Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete

Christoph Hellwig
2018-07-24T07:56:47Z

On Mon, Jul 23, 2018 at 08:37:51AM -0600, Keith Busch wrote:
> The scsi block layer requires requests claimed by the error handling be
> completed by the error handler. A previous commit allowed completions
> to proceed for blk-mq, breaking that assumption.
>
> This patch prevents completions that may race with the timeout handler
> by marking the state to complete, restoring the previous behavior.
>
> Fixes: 12f5b931 ("blk-mq: Remove generation seqeunce")
> Signed-off-by: Keith Busch <keith.busch@intel.com>

Looks good enough (reluctantly) for this merge window:

Reviewed-by: Christoph Hellwig <hch@lst.de>