From: Bart Van Assche <bvanassche@acm.org>
To: Yang Yang <yang.yang@vivo.com>, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Ming Lei <ming.lei@redhat.com>, Omar Sandoval <osandov@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v8] sbitmap: fix io hung due to race on sbitmap_word::cleared
Date: Tue, 16 Jul 2024 14:01:22 -0700 [thread overview]
Message-ID: <be0587f8-f4ea-4e37-b87e-569b26f10536@acm.org> (raw)
In-Reply-To: <20240716082644.659566-1-yang.yang@vivo.com>
On 7/16/24 1:26 AM, Yang Yang wrote:
> This patch achieves two purposes:
> 1. Check on ->cleared and update on both ->cleared and ->word need to
> be done atomically, and using spinlock could be the simplest solution.
> 2. Add extra check in sbitmap_deferred_clear(), to identify whether
> ->word has free bits.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-07-16 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 8:26 [PATCH v8] sbitmap: fix io hung due to race on sbitmap_word::cleared Yang Yang
2024-07-16 21:01 ` Bart Van Assche [this message]
2024-07-19 15:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be0587f8-f4ea-4e37-b87e-569b26f10536@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=yang.yang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox