From: Bart Van Assche <bvanassche@acm.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dongliang Cui <dongliang.cui@unisoc.com>,
axboe@kernel.dk, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, ebiggers@kernel.org,
ke.wang@unisoc.com, hongyu.jin.cn@gmail.com,
niuzhiguo84@gmail.com, hao_hao.wang@unisoc.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
akailash@google.com, cuidongliang390@gmail.com
Subject: Re: [PATCH v4] block: Add ioprio to block_rq tracepoint
Date: Tue, 11 Jun 2024 10:09:12 -0700 [thread overview]
Message-ID: <be0dc105-e205-4b0e-9bd4-49690249fd26@acm.org> (raw)
In-Reply-To: <20240611125440.6d095270@gandalf.local.home>
On 6/11/24 9:54 AM, Steven Rostedt wrote:
> On Tue, 11 Jun 2024 09:26:54 -0700
> Bart Van Assche <bvanassche@acm.org> wrote:
>
>> On 6/11/24 12:35 AM, Dongliang Cui wrote:
>>> +#define IOPRIO_CLASS_STRINGS \
>>> + { IOPRIO_CLASS_NONE, "none" }, \
>>> + { IOPRIO_CLASS_RT, "rt" }, \
>>> + { IOPRIO_CLASS_BE, "be" }, \
>>> + { IOPRIO_CLASS_IDLE, "idle" }, \
>>> + { IOPRIO_CLASS_INVALID, "invalid"}
>>
>> Shouldn't this array be defined in a C file instead of in a header file?
>
> The way the TRACE_EVENT() macro works, this will not work in a C file.
Hmm ... if the above array is terminated with a { -1, NULL } sentinel and if
__print_symbolic() is changed into trace_print_symbols_seq(p, ...) then the above
array can be moved into a C file, isn't it?
Thanks,
Bart.
next prev parent reply other threads:[~2024-06-11 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 7:35 [PATCH v4] block: Add ioprio to block_rq tracepoint Dongliang Cui
2024-06-11 16:26 ` Bart Van Assche
2024-06-11 16:54 ` Steven Rostedt
2024-06-11 17:09 ` Bart Van Assche [this message]
2024-06-11 17:17 ` Steven Rostedt
2024-06-11 17:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be0dc105-e205-4b0e-9bd4-49690249fd26@acm.org \
--to=bvanassche@acm.org \
--cc=akailash@google.com \
--cc=axboe@kernel.dk \
--cc=cuidongliang390@gmail.com \
--cc=dongliang.cui@unisoc.com \
--cc=ebiggers@kernel.org \
--cc=hao_hao.wang@unisoc.com \
--cc=hongyu.jin.cn@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox