Linux block layer
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH] docs: sysfs-block: document size sysfs entry
Date: Fri, 5 Apr 2024 10:42:29 -0700	[thread overview]
Message-ID: <be24545e-55b9-4fa5-8189-263f981f50d2@acm.org> (raw)
In-Reply-To: <20240405165434.12673-1-ikegami.t@gmail.com>

On 4/5/24 09:54, Tokunori Ikegami wrote:
> Document it since /sys/block/<disk>/size is undocumented.
> 
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> ---
>   Documentation/ABI/stable/sysfs-block | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> index 7718ed34777e..881049419054 100644
> --- a/Documentation/ABI/stable/sysfs-block
> +++ b/Documentation/ABI/stable/sysfs-block
> @@ -707,6 +707,13 @@ Description:
>   		zoned will report "none".
>   
>   
> +What:		/sys/block/<disk>/size
> +Date:		April 2024
> +Contact:	linux-block@vger.kernel.org
> +Description:
> +		[RO] This is the 512 bytes size sector number.

What is a "sector number"? Please change the description into something 
like the following:

   [RO] Size of the block device in units of 512 bytes.

Thanks,

Bart.


  reply	other threads:[~2024-04-05 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 16:54 [PATCH] docs: sysfs-block: document size sysfs entry Tokunori Ikegami
2024-04-05 17:42 ` Bart Van Assche [this message]
2024-04-05 21:26   ` Tokunori Ikegami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be24545e-55b9-4fa5-8189-263f981f50d2@acm.org \
    --to=bvanassche@acm.org \
    --cc=ikegami.t@gmail.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox