From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] block: pre-allocate requests if plug is started and is a batch
Date: Wed, 6 Oct 2021 11:24:47 -0700 [thread overview]
Message-ID: <bf1418a7-127d-dbd7-6fef-6351bfe2abe4@acm.org> (raw)
In-Reply-To: <20211006163522.450882-3-axboe@kernel.dk>
On 10/6/21 9:35 AM, Jens Axboe wrote:
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 3b967053e9f5..4b2006ec8bf2 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -22,6 +22,7 @@ struct bio_crypt_ctx;
>
> struct block_device {
> sector_t bd_start_sect;
> + sector_t bd_nr_sectors;
> struct disk_stats __percpu *bd_stats;
> unsigned long bd_stamp;
> bool bd_read_only; /* read-only policy */
Hmm ... I can't find any code in this patch that sets bd_nr_sectors? Did
I perhaps overlook something?
Thanks,
Bart.
next prev parent reply other threads:[~2021-10-06 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:35 [PATCHSET RFC 0/3] Add plug based request allocation batching Jens Axboe
2021-10-06 16:35 ` [PATCH 1/3] block: bump max plugged deferred size from 16 to 32 Jens Axboe
2021-10-06 17:55 ` Bart Van Assche
2021-10-06 18:05 ` Jens Axboe
2021-10-06 16:35 ` [PATCH 2/3] block: pre-allocate requests if plug is started and is a batch Jens Axboe
2021-10-06 18:24 ` Bart Van Assche [this message]
2021-10-06 18:27 ` Jens Axboe
2021-10-06 16:35 ` [PATCH 3/3] io_uring: inform block layer of how many requests we are submitting Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-10-06 23:13 [PATCHSET v2 0/3] Add plug based request allocation batching Jens Axboe
2021-10-06 23:13 ` [PATCH 2/3] block: pre-allocate requests if plug is started and is a batch Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf1418a7-127d-dbd7-6fef-6351bfe2abe4@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).