From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57AF1C433FE for ; Tue, 29 Nov 2022 17:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235993AbiK2RyA (ORCPT ); Tue, 29 Nov 2022 12:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235974AbiK2RyA (ORCPT ); Tue, 29 Nov 2022 12:54:00 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE7852BB1A for ; Tue, 29 Nov 2022 09:53:58 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id x66so14415082pfx.3 for ; Tue, 29 Nov 2022 09:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xli9vLCEDtXh1Vn33pOpeSIt22szJ79NH9QfJ1/hCFI=; b=rnete2628Hvjc5JnCt8Q7ltyJnmZdSp9s1qJoUrljVKf2KKDbT5ljd9bWFPCmnTPoH xi1/zyERiln1rGEVXHl/1xzQaQ1y7vrXTRP/NYMRHaadv2IatDHf3xBwITkNXkcO+SjO +nDh7xGMCoVWGd+f77Z7byqi/iQ/D4MvqFdAyOieVo7HVq+AdkodTeR+BCwbbq/rmO4m cj9gMpyU3kTMN6DSqs1EqnvIHm75Y3JRW2n7agG4s0BvNheokyFDGj9ZzZX0gs5EG9z5 187qFSyHShueZg2m0LaeI/IKReDVF5+snwpg/k4dWb9uyJEsj1z6l47yWEx/BLZpMAQW lRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xli9vLCEDtXh1Vn33pOpeSIt22szJ79NH9QfJ1/hCFI=; b=F+cITHli7cXPIteX/Afvdvk3Z4PYfWI3VPWJFJZXhT3gtzfFjiMedc45GOe+KSbI62 MYaeGGXs/fuML9x8e+TX02Dil6wxZQqkLAACIQyNac1cgjq40Gv6AO0M4noM5F0rbqwJ PAY7JGhaqx9ign0fWnaYwwOEfhcc1hpJXTQYQ8sp+peNEegqATWmgeFeZbDIzNHUqWkd GpYiO4fJq9DKRcm4yUKhng6PUx10oTeatVdM3CbRr6Ij8auPKAjEnEDc0k3/6iSKQu1c bqAp9FWAFty+/spicqRioB+rIx2s+GouX9s0UV28q9HPHb3+iJ+gB1O01EnItsqwZgAx zfPQ== X-Gm-Message-State: ANoB5plZoYr9PpkoNsTZ/NkaphEyZXj4K/gNoM7P7mOEjFmCfOCFJxoM dtyhBnVdXzlpEClIzg1q1LGzKw== X-Google-Smtp-Source: AA0mqf68+0UInZ79fmb6DL13+mxpSI9oXKNi01Izlzc+q4wolcGLb+Om+efE6TIVJSAwdMBcKg6rbw== X-Received: by 2002:a05:6a00:1d25:b0:562:5f71:d188 with SMTP id a37-20020a056a001d2500b005625f71d188mr40014334pfx.57.1669744438171; Tue, 29 Nov 2022 09:53:58 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id p5-20020a1709026b8500b00188c9c11559sm11201218plk.1.2022.11.29.09.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 09:53:57 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:53:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 0/5] random improvements and cleanups for elevator.c Content-Language: en-US To: Jinlong Chen Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/29/22 8:46 AM, Jinlong Chen wrote: > The series slightly improves the readability of elevator.c. > > Changes in v2: > - add patch 3 to further improve the readability (suggested by Christoph) > - add Reviewed-by tags from Christoph > > Jinlong Chen (5): > elevator: print none at first in elv_iosched_show even if the queue > has a scheduler > elevator: replace continue with else-if in elv_iosched_show > elevator: print e->elevator_name instead of cur->elevator_name in > elv_iosched_show > elevator: repalce "len+name" with "name+len" in elv_iosched_show > elevator: use bool instead of int as the return type of > elv_iosched_allow_bio_merge > > block/elevator.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) Applied, with some commit message re-formatting. Please keep lines <= 74 chars. -- Jens Axboe