public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	ulf.hansson@linaro.org, broonie@kernel.org,
	linus.walleij@linaro.org, bfq-iosched@googlegroups.com
Subject: Re: [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally
Date: Tue, 26 Jun 2018 22:35:19 +0200	[thread overview]
Message-ID: <c0098394dac86d23935276a6d25d1f3a@natalenko.name> (raw)
In-Reply-To: <20180625195537.7769-1-paolo.valente@linaro.org>

Hi.

On 25.06.2018 21:55, Paolo Valente wrote:
> Hi,
> during some bandwidth tests, I found some occasional but severe
> malfunctions (losses of bandwidth control). The first three patches in
> this series fix the bugs that caused these malfunctions. The last
> patch is a fix/improvement of the name of one of the functions
> involved with these bugs.
> 
> I guess these patches are appropriate for next kernel release.
> 
> Thanks,
> Paolo
> 
> Paolo Valente (4):
>   block, bfq: add/remove entity weights correctly
>   block, bfq: do not expire a queue that will deserve dispatch plugging
>   block, bfq: fix service being wrongly set to zero in case of
>     preemption
>   block, bfq: give a better name to bfq_bfqq_may_idle
> 
>  block/bfq-iosched.c | 131 
> +++++++++++++++++++++++++++++++++++++++++++---------
>  block/bfq-iosched.h |   7 ++-
>  block/bfq-wf2q.c    |  30 ++++++------
>  3 files changed, 128 insertions(+), 40 deletions(-)
> 
> --
> 2.16.1

So far, no smoke or visible issues while running it on my 2 SSDs with a 
daily workload applied.

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

Thanks.

-- 
   Oleksandr Natalenko (post-factum)

  parent reply	other threads:[~2018-06-26 20:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 19:55 [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally Paolo Valente
2018-06-25 19:55 ` [PATCH BUGFIX RESEND 1/4] block, bfq: add/remove entity weights correctly Paolo Valente
2018-06-25 19:55 ` [PATCH BUGFIX RESEND 2/4] block, bfq: do not expire a queue that will deserve dispatch plugging Paolo Valente
2018-06-25 19:55 ` [PATCH BUGFIX RESEND 3/4] block, bfq: fix service being wrongly set to zero in case of preemption Paolo Valente
2018-06-25 19:55 ` [PATCH BUGFIX RESEND 4/4] block, bfq: give a better name to bfq_bfqq_may_idle Paolo Valente
2018-06-26 16:23 ` [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally Holger Hoffstätte
2018-06-26 20:35 ` Oleksandr Natalenko [this message]
2018-06-28 19:17 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0098394dac86d23935276a6d25d1f3a@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=axboe@kernel.dk \
    --cc=bfq-iosched@googlegroups.com \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox