Linux block layer
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: mst@redhat.com, axboe@kernel.dk, pbonzini@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues
Date: Fri, 3 Feb 2017 17:56:30 +0800	[thread overview]
Message-ID: <c0f97bcc-9675-c725-6d13-9b1181aafced@redhat.com> (raw)
In-Reply-To: <20170203095219.GA28483@lst.de>



On 2017年02月03日 17:52, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 05:47:41PM +0800, Jason Wang wrote:
>>> No, we need to allocate the array larger in that case as want proper
>>> names for the interrupts.
>> Consider the case of !per_vq_vectors, the size of msix_names is 2, but
>> snprintf can do out of bound accessing here. (We name the msix shared by
>> virtqueues with something like "%s-virtqueues" before the patch).
> Yes, that's what I meant above - we need to allocate a large array
> starting with this patch.  I'll fix it up for the next version.

I see.

Thanks

  reply	other threads:[~2017-02-03  9:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27  8:16 automatic IRQ affinity for virtio V2 Christoph Hellwig
2017-01-27  8:16 ` [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info Christoph Hellwig
2017-02-03  7:54   ` Jason Wang
2017-02-03  8:22     ` Christoph Hellwig
2017-01-27  8:16 ` [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig
2017-02-03  7:54   ` Jason Wang
2017-02-03  8:26     ` Christoph Hellwig
2017-02-03  9:47       ` Jason Wang
2017-02-03  9:52         ` Christoph Hellwig
2017-02-03  9:56           ` Jason Wang [this message]
2017-01-27  8:16 ` [PATCH 3/9] virtio_pci: don't duplicate the msix_enable flag in struct pci_dev Christoph Hellwig
2017-02-03  7:56   ` Jason Wang
2017-01-27  8:16 ` [PATCH 4/9] virtio_pci: simplify MSI-X setup Christoph Hellwig
2017-02-03  7:57   ` Jason Wang
2017-01-27  8:16 ` [PATCH 5/9] virtio: allow drivers to request IRQ affinity when creating VQs Christoph Hellwig
2017-02-03  8:01   ` Jason Wang
2017-01-27  8:16 ` [PATCH 6/9] virtio: provide a method to get the IRQ affinity mask for a virtqueue Christoph Hellwig
2017-02-03  8:02   ` Jason Wang
2017-01-27  8:16 ` [PATCH 7/9] blk-mq: provide a default queue mapping for virtio device Christoph Hellwig
2017-01-27  8:16 ` [PATCH 8/9] virtio_blk: use virtio IRQ affinity Christoph Hellwig
2017-01-27  8:16 ` [PATCH 9/9] virtio_scsi: " Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2017-02-05 17:15 automatic IRQ affinity for virtio V3 Christoph Hellwig
2017-02-05 17:15 ` [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues Christoph Hellwig
2017-02-07  7:17   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0f97bcc-9675-c725-6d13-9b1181aafced@redhat.com \
    --to=jasowang@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox