From: Bart Van Assche <bvanassche@acm.org>
To: chengming.zhou@linux.dev, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: Re: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field
Date: Thu, 20 Jul 2023 08:36:22 -0700 [thread overview]
Message-ID: <c2d10567-cfc6-de6b-cc08-21ab00604d51@acm.org> (raw)
In-Reply-To: <20230720095512.1403123-1-chengming.zhou@linux.dev>
On 7/20/23 02:55, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> This counter is not used anywhere, so delete it.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> include/linux/blk-mq.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 01e8c31db665..958ed7e89b30 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -393,8 +393,6 @@ struct blk_mq_hw_ctx {
> */
> struct blk_mq_tags *sched_tags;
>
> - /** @queued: Number of queued requests. */
> - unsigned long queued;
> /** @run: Number of dispatched requests. */
> unsigned long run;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-07-20 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 9:55 [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field chengming.zhou
2023-07-20 15:36 ` Bart Van Assche [this message]
2023-07-20 19:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d10567-cfc6-de6b-cc08-21ab00604d51@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=chengming.zhou@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).