From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F56215172; Thu, 9 Jan 2025 09:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413461; cv=none; b=HnhkTnPMx54ndCQNKUhq9yKBAaLH+EO0ScjSjEAIB5v1gkM59r7ouu8GYIWEnp/2jI250E48ELSG1nLtZOX4shFqEmQPDzO3Qxh7OQ3wv0BlvOhSjMxrnhOUc0f/HySzJljCxf48bn+14E97maAGNecNNh7Y8wAkMfWxuiB3aT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413461; c=relaxed/simple; bh=tgdl5m2HchNQkxrEf0TMxKH5f7l513q5SCryQu6F/VU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t9vx91wlwYbusDNxixvm4GfGAtvBNACUm/Ta9p1nR6OlWYrUDNu5fRPkRTgdIrFnEUDdpO/eEP8CWgBL8tPO/3sQA1DvgaHr0K5HSlig6uDFTFQCDwurT3gj/BVmI5yN2ph6knVnEls59RqlS9tiPnDsMD3lB5Z9j5wtdPbpSgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=aJFhay3J; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="aJFhay3J" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5093qUu9005305; Thu, 9 Jan 2025 09:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=l/LNgd J3X41kyHYEfqchK/B/OMLKba7Bna5ZeeYJCcc=; b=aJFhay3J9HTWE2hibWgZeS g+/WwRAK9JGUfR/yegoeYOFMgjj2eEBwCgsk/Eq6mqhD9+eBxvQutP/GSRpo3Ghn X2TDz7VFDOf0yvGvf8yG6C4w4lNva5+3a28T+e52mvhLEQmH2/KCuVaJT47zknvW e2TgZqR/3coetnLSjFUGobpkygN2zs4TdxytONSl3gu9UTIJEEU0TQwck+6KrtKT Xr+XKdBPmnLPUcBQ2qQPvKbmq/ptRVTmnflfwzrg75h9kupw6qB/1865SxfKzLKn g1ovZO/9Kvcr1u8Ed6V4g1wvTYzol8gOhxf6xcvIwkG8txL/y3YvV8iKFXjDvCrw == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4426xc96su-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 09:04:05 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5098CpGM008869; Thu, 9 Jan 2025 09:04:04 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yfq04g13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 09:04:04 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 509943kb31654642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Jan 2025 09:04:03 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C53E95805D; Thu, 9 Jan 2025 09:04:03 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9EB3D58058; Thu, 9 Jan 2025 09:04:00 +0000 (GMT) Received: from [9.171.90.198] (unknown [9.171.90.198]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 9 Jan 2025 09:04:00 +0000 (GMT) Message-ID: Date: Thu, 9 Jan 2025 14:33:59 +0530 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/11] block: check BLK_FEAT_POLL under q_usage_count To: Christoph Hellwig , Jens Axboe Cc: Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250109055810.1402918-1-hch@lst.de> <20250109055810.1402918-4-hch@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20250109055810.1402918-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: K5lR1t4kQGyPizKm16dwYsbsFGZOWOe8 X-Proofpoint-ORIG-GUID: K5lR1t4kQGyPizKm16dwYsbsFGZOWOe8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=723 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501090074 On 1/9/25 11:27 AM, Christoph Hellwig wrote: > Otherwise feature reconfiguration can race with I/O submission. > > Also drop the bio_clear_polled in the error path, as the flag does not > matter for instant error completions, it is a left over from when we > allowed polled I/O to proceed unpolled in this case. > > Signed-off-by: Christoph Hellwig Looks good to me: Reviewed-by: Nilay Shroff