From: Jens Axboe <axboe@kernel.dk>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: tj@kernel.org, baolin.wang7@gmail.com,
linux-block@vger.kernel.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Some improvements for blk-throttle
Date: Tue, 15 Sep 2020 12:17:57 -0600 [thread overview]
Message-ID: <c36a1c1b-ca46-13c8-42eb-94e63ff845d1@kernel.dk> (raw)
In-Reply-To: <20200915085926.GA122937@VM20190228-100.tbsite.net>
On 9/15/20 2:59 AM, Baolin Wang wrote:
> Hi Jens,
>
> On Mon, Sep 14, 2020 at 07:37:53PM -0600, Jens Axboe wrote:
>> On 9/7/20 2:10 AM, Baolin Wang wrote:
>>> Hi All,
>>>
>>> This patch set did some clean-ups, as well as removing some unnecessary
>>> bps/iops limitation calculation when checking if can dispatch a bio or
>>> not for a tg. Please help to review. Thanks.
>>>
>>> Baolin Wang (5):
>>> blk-throttle: Fix some comments' typos
>>> blk-throttle: Use readable READ/WRITE macros
>>> blk-throttle: Define readable macros instead of static variables
>>> blk-throttle: Avoid calculating bps/iops limitation repeatedly
>>> blk-throttle: Avoid checking bps/iops limitation if bps or iops is
>>> unlimited
>>>
>>> block/blk-throttle.c | 59 ++++++++++++++++++++++++++++++++--------------------
>>> 1 file changed, 36 insertions(+), 23 deletions(-)
>>
>> Looks reasonable to me, I've applied it.
>
> Thanks.
>
>>
>> Out of curiosity, are you using blk-throttle in production, or are these
>> just fixes/cleanups that you came across?
>
> Yes, we're using it in some old products, and I am trying to do some
> cleanups and optimizaiton when testing it.
Gotcha. Reason I ask is I've been considering deprecating it, but when
fixes come in for something, that always makes me think that some folks
are actually using it.
--
Jens Axboe
prev parent reply other threads:[~2020-09-15 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 8:10 [PATCH 0/5] Some improvements for blk-throttle Baolin Wang
2020-09-07 8:10 ` [PATCH 1/5] blk-throttle: Fix some comments' typos Baolin Wang
2020-09-07 8:10 ` [PATCH 2/5] blk-throttle: Use readable READ/WRITE macros Baolin Wang
2020-09-07 8:10 ` [PATCH 3/5] blk-throttle: Define readable macros instead of static variables Baolin Wang
2020-09-07 8:10 ` [PATCH 4/5] blk-throttle: Avoid calculating bps/iops limitation repeatedly Baolin Wang
2020-09-07 8:10 ` [PATCH 5/5] blk-throttle: Avoid checking bps/iops limitation if bps or iops is unlimited Baolin Wang
2020-09-14 5:32 ` [PATCH 0/5] Some improvements for blk-throttle Baolin Wang
2020-09-15 1:37 ` Jens Axboe
2020-09-15 8:59 ` Baolin Wang
2020-09-15 18:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36a1c1b-ca46-13c8-42eb-94e63ff845d1@kernel.dk \
--to=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).