From: Pankaj Raghav <p.raghav@samsung.com>
To: Christoph Hellwig <hch@lst.de>,
"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Cc: <axboe@kernel.dk>, <linux-block@vger.kernel.org>
Subject: Re: can we drop the bio based path in null_blk
Date: Thu, 25 Jan 2024 10:07:35 +0100 [thread overview]
Message-ID: <c3a537ee-7b93-4337-a795-cbd2647a8201@samsung.com> (raw)
In-Reply-To: <20240125081502.GC21006@lst.de>
On 25/01/2024 09:15, Christoph Hellwig wrote:
> On Wed, Jan 24, 2024 at 09:31:25PM +0100, Pankaj Raghav (Samsung) wrote:
>> The subject says removing the bio mode in null_blk but here you are
>> asking an open question about the non-so-relevant ones should move to
>> blk-mq. My input is for the latter part, FWIW.
>
> Well, it's two different things. My prime concern right now is
> null_blk, which is very clumsy due to the two different I/O paths,
> and actually broken in that the bio mode doesn't respect various
> I/O limits that can be configured, and at least in zone modes also
> ones that aren't configured but required (I/Os spanning zones).
>
My 2 cents: The drivers that still use submit_bio are mostly memory
based except for n64. And there is only one blktest(block/023) that
tests the bio path (Shinchiro can comment here if this is wrong).
So we could remove the submit_bio path in null_blk to simplify things
as most of the drivers that uses this path do not do anything complicated
in submit_bio and are mostly memory based.
--
Pankaj Raghav
prev parent reply other threads:[~2024-01-25 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 8:49 can we drop the bio based path in null_blk Christoph Hellwig
2024-01-23 9:13 ` Hannes Reinecke
2024-01-24 20:31 ` Pankaj Raghav (Samsung)
2024-01-24 22:00 ` Jens Axboe
2024-01-25 8:15 ` Christoph Hellwig
2024-01-25 8:57 ` Chaitanya Kulkarni
2024-01-25 9:07 ` Pankaj Raghav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3a537ee-7b93-4337-a795-cbd2647a8201@samsung.com \
--to=p.raghav@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox