From: Bart Van Assche <bvanassche@acm.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
Date: Thu, 27 Jul 2023 08:18:41 -0700 [thread overview]
Message-ID: <c3bff0d9-957a-fbb7-a433-4cab457c62bf@acm.org> (raw)
In-Reply-To: <kya2ayzcgz7iemknkx6xuef4m37f2ms7rt3uxamtxr2w7zbwfc@onladguxa7bk>
On 7/27/23 00:11, Daniel Wagner wrote:
> On Wed, Jul 26, 2023 at 07:54:24AM -0700, Bart Van Assche wrote:
>> On 7/26/23 05:46, Daniel Wagner wrote:
>>> Group all variable declarations together at the beginning of the
>>> function.
>>
>> An explanation of why this change has been proposed is missing from the
>> patch description.
>
> Sure, I'll add one. The coding style to declare all local variables at the
> beginning of the function.
Isn't declaring local variables just before their first use a better style?
Thanks,
Bart.
next prev parent reply other threads:[~2023-07-27 15:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 12:46 [PATCH blktests v1 00/11] Switch to allowed_host Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations Daniel Wagner
2023-07-26 14:54 ` Bart Van Assche
2023-07-27 7:11 ` Daniel Wagner
2023-07-27 15:18 ` Bart Van Assche [this message]
2023-07-28 5:06 ` Shinichiro Kawasaki
2023-07-28 6:46 ` Daniel Wagner
2023-07-28 7:58 ` Shinichiro Kawasaki
2023-07-26 12:46 ` [PATCH blktests v1 02/11] nvme: Reorganize test preamble code section Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 03/11] nvme/rc: Add common subsystem nqn define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 04/11] nvme: Use def_subsysnqn variable instead local variable Daniel Wagner
2023-07-28 8:04 ` Shinichiro Kawasaki
2023-07-26 12:46 ` [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid Daniel Wagner
2023-07-28 8:10 ` Shinichiro Kawasaki
2023-07-28 8:52 ` Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 06/11] nvme/rc: Add common file_path name define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 07/11] nvme: Use def_file_path variable instead local variable Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 08/11] nvme/rc: Add common def_subsys_uuid define Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 09/11] nvme: Use def_subsys_uuid variable Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 10/11] nvme/rc: Add helper for adding/removing to allow list Daniel Wagner
2023-07-26 12:46 ` [PATCH blktests v1 11/11] nvme: Add explicitly host to allow_host list Daniel Wagner
2023-07-28 8:15 ` Shinichiro Kawasaki
2023-07-28 8:55 ` Daniel Wagner
2023-07-28 8:20 ` [PATCH blktests v1 00/11] Switch to allowed_host Shinichiro Kawasaki
2023-07-28 8:59 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bff0d9-957a-fbb7-a433-4cab457c62bf@acm.org \
--to=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).