Re: [PATCH 1/6] sed-opal: add IOC_OPAL_REACTIVATE_LSP.

[Milan Broz <gmazyland@gmail.com>]

On 1/30/26 5:25 PM, Ondrej Kozina wrote:
> This adds the 'Reactivate' method as described in the
> "TCG Storage Opal SSC Feature Set: Single User Mode"
> document (ch. 3.1.1.1).
> 
> The method enables switching an already active SED OPAL2 device,
> with appropriate firmware support for Single User Mode (SUM),
> to or from SUM.
> 
> Signed-off-by: Ondrej Kozina <okozina@redhat.com>
> ---
>   block/opal_proto.h            |  4 ++
>   block/sed-opal.c              | 91 +++++++++++++++++++++++++++++++++++
>   include/linux/sed-opal.h      |  1 +
>   include/uapi/linux/sed-opal.h | 14 ++++++
>   4 files changed, 110 insertions(+)
> 
> diff --git a/block/opal_proto.h b/block/opal_proto.h
> index d247a457bf6e..d138785b8198 100644
> --- a/block/opal_proto.h
> +++ b/block/opal_proto.h
> @@ -125,6 +125,7 @@ enum opal_uid {
>   	OPAL_LOCKING_INFO_TABLE,
>   	OPAL_ENTERPRISE_LOCKING_INFO_TABLE,
>   	OPAL_DATASTORE,
> +	OPAL_LOCKING_TABLE,

This addition should be mentioned in commit messages.

Perhaps separate new UID definitions to another patch.

> @@ -2287,6 +2291,64 @@ static int activate_lsp(struct opal_dev *dev, void *data)
>   	return finalize_and_send(dev, parse_and_check_status);
>   }
>   
> +static int reactivate_lsp(struct opal_dev *dev, void *data)
> +{
> +	struct opal_lr_react *opal_react = data;
> +	u8 user_lr[OPAL_UID_LENGTH];
> +	int err, i;
> +
> +	err = cmd_start(dev, opaluid[OPAL_THISSP_UID],
> +			opalmethod[OPAL_REACTIVATE]);
> +
> +	if (err) {
> +		pr_debug("Error building Reactivate LockingSP command.\n");
> +		return err;
> +	}
> +

Hera I would add comment describing which variants it implement
  - set SUM for whole locking table (no list)
  - set SUM for separate LRs
and how it differs.

> +	if (opal_react->entire_table) {
> +		add_token_u8(&err, dev, OPAL_STARTNAME);
> +		add_token_u64(&err, dev, OPAL_SUM_SET_LIST);
> +		add_token_bytestring(&err, dev, opaluid[OPAL_LOCKING_TABLE], OPAL_UID_LENGTH);
> +		add_token_u8(&err, dev, OPAL_ENDNAME);
> +	} else if (opal_react->num_lrs) {
> +		err = build_locking_range(user_lr, sizeof(user_lr),
> +					  opal_react->lr[0]);
> +		if (err)
> +			return err;
> +
> +		add_token_u8(&err, dev, OPAL_STARTNAME);
> +		add_token_u64(&err, dev, OPAL_SUM_SET_LIST);
> +
> +		add_token_u8(&err, dev, OPAL_STARTLIST);
> +		add_token_bytestring(&err, dev, user_lr, OPAL_UID_LENGTH);
> +		for (i = 1; i < opal_react->num_lrs; i++) {
> +			user_lr[7] = opal_react->lr[i];
> +			add_token_bytestring(&err, dev, user_lr, OPAL_UID_LENGTH);
> +		}
> +		add_token_u8(&err, dev, OPAL_ENDLIST);
> +

Remove empty line here?

> +		add_token_u8(&err, dev, OPAL_ENDNAME);
> +	}
> +
> +	/* Skipping the rangle policy parameter is same as setting its value to zero */
> +	if (opal_react->range_policy && (opal_react->num_lrs || opal_react->entire_table)) {
> +		add_token_u8(&err, dev, OPAL_STARTNAME);
> +		add_token_u64(&err, dev, OPAL_SUM_RANGE_POLICY);
> +		add_token_u8(&err, dev, 1);
> +		add_token_u8(&err, dev, OPAL_ENDNAME);
> +	}
> +

This is optional, if not set, admin key remains unchanged. Add comment?

> +	if (opal_react->new_admin_key.key_len) {
> +		add_token_u8(&err, dev, OPAL_STARTNAME);
> +		add_token_u64(&err, dev, OPAL_SUM_ADMIN1_PIN);
> +		add_token_bytestring(&err, dev, opal_react->new_admin_key.key,
> +				     opal_react->new_admin_key.key_len);
> +		add_token_u8(&err, dev, OPAL_ENDNAME);
> +	}

...


Otherwise looks good.

Milan

p.s.
I implemented similar code in userspace for opal-toolset and tested on several drives.

Original sedutils do not implement SUM / reactivate at all.

That said, there are many drives that have broken SUM implementation... but I am pretty
sure the construction above is according to TCG standard.