From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "hch@lst.de" , "keith.busch@linux.intel.com" CC: "linux-scsi@vger.kernel.org" , "keith.busch@intel.com" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "axboe@kernel.dk" , "jianchao.w.wang@oracle.com" Subject: Re: [PATCH 2/2] scsi: set timed out out mq requests to complete Date: Mon, 23 Jul 2018 13:59:36 +0000 Message-ID: References: <20180719212618.2406-1-keith.busch@intel.com> <20180719212618.2406-2-keith.busch@intel.com> <1073d0d2902327970c4e28a4c7c97a21fd8885c8.camel@wdc.com> <20180720155646.GE4093@localhost.localdomain> <2b01f0a8d5864b2563573d46ce5b4ec5f593f538.camel@wdc.com> <20180720161240.GF4093@localhost.localdomain> <092dd4f2dae0cc533018c9fb829a50b4cbb6cb0b.camel@wdc.com> <20180720162321.GG4093@localhost.localdomain> <797120d19f5d15e7d98a3d2f90ce91ebf60690d7.camel@wdc.com> <20180720172444.GH4093@localhost.localdomain> <20180723081231.GB19247@lst.de> In-Reply-To: <20180723081231.GB19247@lst.de> Content-Type: text/plain; charset="utf-7" MIME-Version: 1.0 List-ID: On Mon, 2018-07-23 at 10:12 +-0200, hch+AEA-lst.de wrote: +AD4- Btw, one thing we should do in blk-mq and scsi is to make the time +AD4- optional. If the blk+AF8-mq driver doesn't even have a timeout struc= ture +AD4- there is no point in timing out requests and enter the timeout handle= r +AD4- ever. Are there any blk-mq drivers that do not define a timeout handler and that use shared tags? I think such drivers need periodic calls to blk+AF8-mq+AF8= -tag+AF8-idle(). Do you perhaps want to happen these calls from another context? Thanks, Bart.=